Point the seven new samples back at their documentation - #845
Merged
Merged
Conversation
The other half of the pairing abap2UI5/docs#322 declares. Each side checks it against the OTHER repository's main - check-docs-links here wants the page to name the class, link-samples.mjs there wants the class to point back - so the two cannot both be green until both have merged. #844 went in without these lines to keep that side clean; this restores them once the pages exist. 513, 514, 515, 518 cookbook/event_navigation/frontend 516 cookbook/browser_interaction/soft_keyboard 517 cookbook/device_capabilities/upload_download 519 cookbook/translation_messages/translation_i18n The `docs:` rows in SAMPLES.md and the catalogue entries come back with them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rmo8XKoBEpBRZ2TZMUQrF
oblomov-dev
added a commit
to abap2UI5/docs
that referenced
this pull request
Sep 14, 2026
513, 514, 515 and 518 on cookbook/event_navigation/frontend, 516 beside 352 on soft_keyboard, 517 beside 074 on upload_download, and 519 on translation_i18n, which had no samples block at all. The generated blocks are rewritten with npm run link:samples; nothing else on any page changes. Merged with `check` red, deliberately. The pairing is enforced in BOTH directions against the other repository's main - link-samples.mjs here wants the class to point back, check-docs-links there wants the page to name the class - so the two halves can never both be green before both have merged. abap2UI5/samples#845 carries the other half and turns both sides green; it was open and verified against this branch before this went in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other half of the pairing abap2UI5/docs#322 declares.
cookbook/event_navigation/frontendcookbook/browser_interaction/soft_keyboardcookbook/device_capabilities/upload_downloadcookbook/translation_messages/translation_i18nThe
docs:rows inSAMPLES.mdand the catalogue entries come back with them.Why this is a second pull request
Each side checks the pairing against the other repository's
main, and both directions are enforced:check-docs-linkshere wants the page to name the class (.github/workflows/check-docs-links.yaml,ref: main);link-samples.mjsthere wants the class to point back (backlinks: true).So a new sample and its page entry can never both be green before both have merged — whichever lands first is red until the other does. #844 went in without these lines to keep that side clean; this one is red until abap2UI5/docs#322 merges, and green the moment it does.
Everything that does not depend on the other repository passes: abaplint v750 and Cloud, the 702 downport, abap2ui5-linter 0 failing, and every generated artefact regenerated.
🤖 Generated with Claude Code
https://claude.ai/code/session_019rmo8XKoBEpBRZ2TZMUQrF
Generated by Claude Code