Seven deprecated names are removed, not just superseded - #318
Merged
Merged
Conversation
It is gone from z2ui5_if_client on main, so the page says removed instead of obsolete-but-still-compiles: the status table marks it removed for the next release, and the section says a call that still names it does not compile. The migration is unchanged - delete the parameter - and the note that cs_view itself stays, as the view slot of follow_up_action( ), is new. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YHQHEFhPm2TQT7M5Sszyn
`cs_event-wizard_set_next_step` and the four obsolete URL-API spellings are gone from `z2ui5_if_client` on main, so the page says removed instead of still-compiles: the status table marks all five removed for the next release, and each section says a call that still names one does not compile. The wizard section additionally says its frontend handler went with the constant, so a raw `WIZARD_SET_NEXT_STEP` string does nothing either, and the URL-API section says the same for `evClipboardAppState`. The migrations are unchanged — two `control_by_id` calls, and the `hash_*` / `app_state_*` names. `resources/changelog.md` keeps its 1.143.0 wording: that is the record of what that release did, not a claim about today. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YHQHEFhPm2TQT7M5Sszyn
`cs_event-set_push_state` and `cs_event-set_app_state_active` were alias constants for `cs_event-hash_set` and `cs_event-app_state_set_active` and are gone with the methods of the same name, so the family is `hash_*` / `app_state_*` and nothing else. The status table names them next to their methods, and the section says so in a line of its own — they were never listed separately, and somebody who used one needs to find it here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YHQHEFhPm2TQT7M5Sszyn
oblomov-dev
added a commit
to abap2UI5/abap2UI5
that referenced
this pull request
Sep 13, 2026
BREAKING. Seven names already marked obsolete, plus the two frontend handlers
that two of them were the only way to reach:
the view parameter of _bind( ) / _bind_edit( ) delete it
cs_event-wizard_set_next_step two control_by_id calls
set_push_state( ), cs_event-set_push_state hash_set( ), cs_event-hash_set
set_app_state_active( ), cs_event-… app_state_set_active( ), …
cs_event-set_nav_routing cs_event-hash_routing
cs_event-clipboard_app_state app_state_get_href( ) +
cs_event-clipboard_copy
`view` had been inert for as long as it carried the obsolete mark - never
passed on internally, a leftover from when each view slot owned a model of its
own. The URL-API removals are renames: each old name shared its wire value with
the surviving one and reached the same branch, so nothing moves on the wire and
the two delegating method bodies are gone rather than reimplemented - which is
why hash_set and app_state_set_active still carry SET_PUSH_STATE /
SET_APP_STATE_ACTIVE as values, and have to: a draft can hold a queued action,
so a changed value invalidates drafts a constant rename does not touch. A
comment at cs_event now says so. clipboard_app_state is the one that is not a
rename: it composed the share link in the browser and could only put it on the
clipboard, while app_state_get_href( ) hands the same link to ABAP.
Ecosystem count at removal: 0 - samples, samples-controls and samples-stack
call none of the seven, and none did in their git history. Converted in-repo:
three client tests, the two e2e hub apps under node/srv, and the guide's
routing block. src/01/03/ regenerated with npm run app2abap; API snapshot
regenerated; recorded as three BREAKING lines in changelog.txt and in
docs/removal-plan.md section 0.
Lands with abap2UI5/app-template#29 (the guide mirror), abap2UI5/linter#105
(the dispatch-table mirror), abap2UI5/docs#318 and
abap2UI5/samples-controls#202, all merged first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation half of abap2UI5/abap2UI5#2752, which removes seven names from
z2ui5_if_client.resources/deprecations.mdsaid each of them still compiles. It does not any more, so the status table marks them removed for the next release and each section says a call that still names one fails at compile time:viewparameter of_bind( )/_bind_edit( )cs_event-wizard_set_next_stepset_push_state( )andcs_event-set_push_stateset_app_state_active( )andcs_event-set_app_state_activecs_event-set_nav_routingcs_event-clipboard_app_stateThe migrations themselves are unchanged — that is the point of the page, and every one of them was already written here.
Three things are new rather than restated:
WIZARD_SET_NEXT_STEPstring does nothing either; the URL-API section says the same forevClipboardAppStatecs_event-set_push_state/cs_event-set_app_state_activeget named. They were never in the table — only their methods were — so somebody who used one had nowhere to lookviewsection notes thatcs_viewitself stays: it is the view slot offollow_up_action( ), where it does select oneresources/changelog.mdkeeps its 1.143.0 wording. That is the record of what that release did, not a claim about today.Verification
npm test(251 pass),check:api-names,check:examples,check:conventions,check:playground,check:images,check:design,docs:buildandcheck:cross-site— all green.Worth noting for the merge order: both
check:api-namesandcheck:examplesexemptresources/deprecations.md(it is the page whose subject is what went away), so this page does not go red once the framework PR lands. No page outside it names any of the seven.🤖 Generated with Claude Code
https://claude.ai/code/session_014YHQHEFhPm2TQT7M5Sszyn
Generated by Claude Code