Skip to content

Deprecations: the message-method options, and Removed gets its own section - #320

Merged
oblomov-dev merged 1 commit into
mainfrom
claude/charming-bardeen-u2w1e4
Sep 14, 2026
Merged

oblomov-dev merged 1 commit into
mainfrom
claude/charming-bardeen-u2w1e4

Conversation

@oblomov-dev

Copy link
Copy Markdown
Member

Read resources/deprecations.md against abap2UI5 main (37302cb) rather than against the last docs change. Most of it was already current — #318 and #319 caught the seven-name removal and the JSON reader yesterday — but four things were not.

The message-method options were missing entirely

abap2UI5#2748 took eleven parameters off message_toast_display( ) (width, my, at, of, offset, collision, autoclose, animationtimingfunction, animationduration, closeonbrowsernavigation, class) and five off message_box_display( ) (textdirection, icon, closeonnavigation, dependenton, contentwidth). It is in the framework's changelog as - BREAKING: and, unlike the six removals recorded before it, it breaks a caller at compile time on the parameter rather than relocating a name — the one entry on the page that shortens a signature.

Nothing on the deprecations page said so: no row in the version-status table, no section. The options were documented only on Message and Frontend Actions, which is where a reader goes to write a message, not where they go to find out what their existing code has to stop doing. Added both, with the cs_event-control_global replacement and a pointer to Message, which already carries the per-control option tables.

"Removed" sections under a heading promising the opposite

Five sections reading Removed. sat under the H2 ## Obsolete: still compiles. They move to their own ## Removed: does not compile any more: the view parameter, cs_event-wizard_set_next_step, the URL API, check_allow_multi_req, and the new message entry. No prose in the moved sections changed.

A control that does not exist

The invisible-controls table listed a SoftKeyboard control, under a paragraph reading "The controls still ship and views that use them keep rendering". There is no such control anywhere in the framework — grep -ri softkeyboard over abap2UI5 is empty and app/webapp/cc/ has no such file. Only cs_event-keyboard_set_mode exists, which is current API and not a deprecation. Row dropped; the Soft Keyboard page it pointed at is still linked from Keyboard Shortcuts.

Two dead sample links

The two AJSON-replacement rows linked src/00/z2ui5_cl_smp_app_507 and _509. samples#843 moved them into src/01, so both 404'd. Repointed — check:samples is what found these.

Regenerated, stale on main

  • The Working Samples blocks on eight pages — the same src/00src/01 move (npm run link:samples).
  • The client API reference — it had not picked up cs_event-store_data from abap2UI5#2755 (npm run generate:api).

Both were already failing on main before this branch; neither is a hand edit.

Gates

test, check:version, docs:build, check:cross-site, check:images, check:examples, check:conventions, check:playground, check:api-names, check:api-reference and check:samples are green locally.

build and check:design could not run in this container: both borrow their four shared assets from the published playground, and this environment's network policy answers 403 for abap2ui5.github.io (no built playground checkout here either). Neither reads a file this PR touches — CI runs both.

One note for whoever works in a container next: the sibling clones' local main refs were up to 18 commits behind their remotes, and generate:api reads A2UI5_HOME at main with git show. Running it against a stale ref silently reverts the API reference — it re-added check_allow_multi_req here before the refs were fast-forwarded. Worth a git fetch before trusting a generator's output.

🤖 Generated with Claude Code

https://claude.ai/code/session_01K1onp9KRonb7yrY7M3vhNS


Generated by Claude Code

…ction

Four gaps on resources/deprecations.md, found by reading it against
abap2UI5 main (37302cb) rather than against the last docs change.

- The UI5 options of message_toast_display( ) and message_box_display( )
  were missing entirely. #2748 took eleven parameters off the toast and
  five off the box, and unlike the six removals recorded before it this
  one breaks a caller at COMPILE time on the parameter rather than
  relocating a name - the one entry on the page that shortens a
  signature. Added to the version-status table and as a section, with
  the cs_event-control_global replacement and a pointer to Message,
  which already carried the option tables.

- Five sections reading "**Removed.**" sat under the H2 "Obsolete:
  still compiles", which promises the opposite of what they say. They
  move to their own H2: the view parameter, wizard_set_next_step, the
  URL API, check_allow_multi_req and the new message entry.

- The invisible-controls table listed a `SoftKeyboard` control under a
  paragraph reading "The controls still ship". There is no such control
  anywhere in the framework - only the cs_event-keyboard_set_mode event,
  which is current API and not a deprecation. Row dropped.

- The two AJSON-replacement samples linked src/00; samples #843 moved
  them into src/01, so both links 404'd. Repointed.

Two generated artefacts were stale on main and are regenerated here:
the Working Samples blocks on eight pages (the same src/01 move) and the
client API reference, which had not picked up cs_event-store_data from
#2755.

Gates: test, check:version, docs:build, check:cross-site, check:images,
check:examples, check:conventions, check:playground, check:api-names,
check:api-reference and check:samples all green. `build` and
check:design could not run in this container - both borrow from the
published playground and the network policy here answers 403 for
abap2ui5.github.io; neither reads a file this commit touches.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K1onp9KRonb7yrY7M3vhNS
@oblomov-dev
oblomov-dev merged commit 44feb8c into main Sep 14, 2026
1 check passed
@oblomov-dev
oblomov-dev deleted the claude/charming-bardeen-u2w1e4 branch September 14, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants