Repository navigation
[WIP][DONTMERGE] Record logcat messages with a recording and list them per frame #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
todi1856
wants to merge
10
commits into
master
Choose a base branch
from
recording-logcat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7c24fb6
Send the device's wall clock with every live stream frame
todi1856 6116469
Record logcat messages with a recording and list them per frame
todi1856 5ea2f63
Show and log typed characters in the sample project
todi1856 d5c341c
Rename AndroidLogcatScreenshotInfo to AndroidLogcatCaptureInfo
todi1856 f7baf48
Draw the recording's logcat messages like the Android Logcat window
todi1856 b54eab3
Update the sample scene
todi1856 6b04ba3
Show the video time range a logcat message was logged in
todi1856 e0da2a7
Address review of logcat message placement
todi1856 33a0551
Log a tick and show the running time in the sample project
todi1856 6d65f30
Update the sample project to the current Editor
todi1856 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At 1 FPS, a log emitted during the throttle wait can be attached to an image captured before that log.
ScreenStreamer.onImageAvailableacquires the image before sleeping, then passes a freshSystem.nanoTime()ascaptureNsafter sleeping.writeFrametherefore stamps the image with the end of the wait rather than its capture time.PlaceLogscan assign messages emitted during that wait to the earlier image. Derive both frame timestamps from the image's capture time. Keep throttling timestamps separate.🤖 Helpful? 👍/👎