Repository navigation
Conversation
Each frame header now carries realtimeUs, the device's wall clock at capture, which is the clock logcat stamps messages with. The frame header grows from 32 to 40 bytes, so the protocol version goes to 3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Start Recording gets a dropdown with Include Logcat Messages, off by default. When enabled, the recording runs its own logcat, filtered as the Android Logcat window is when recording starts, with '-v epoch -v usec' so messages can be placed among the frames using the frame's device wall clock. Each message is saved in the recording's .json, on the frame it was logged before, reusing LogcatEntry, now serializable. When the recording plays, a resizable panel under the video lists the messages with the video time of their frame, highlights the shown frame's, dims later ones, follows the video, and goes to a message's frame on click. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DebugMethods displays what is typed on screen and logs each change, for testing keyboard input and logcat recording from the live view. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The details file describes recordings too, with what changed while they ran, so the name says capture rather than screenshot. JsonUtility doesn't store the class name, so existing .json files load as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The panel under the video now uses the Logcat window's column header, row stripes, selection highlight for the shown frame, priority icons, and the message font and colors from Preferences. The shared columns follow the Logcat window's column widths and visibility, with the video time first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Saved by a newer Editor, with the DebugMethods object that shows typed characters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Video column shows the range from the previous frame to the message's frame, and a message now goes to the first frame at or after it, so frame N lists exactly what was logged after frame N-1, up to frame N. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Read the recording's logcat from the device time of the frame recording started on (-T <seconds>), so messages logged while adb starts aren't missed. - Drop messages logged before the recording by their unrounded time, so one just before the start no longer lands on the first frame. - Place messages by sorting them by frame and merging them into the frame changes in one pass, instead of searching the changes for each message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every 3 seconds DebugMethods logs the time, and the screen shows the time updated every frame, to compare a recording's frames with its logcat panel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ProjectVersion.txt and ProjectSettings.asset as saved by the Editor the project is now opened with. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
/review |
| out.writeLong((captureNs - firstFrameNs) / 1000L); | ||
| // The clock logcat stamps messages with, so the Editor can place them among | ||
| // the frames. Taken back by the frame's age, as it was captured a moment ago. | ||
| out.writeLong(System.currentTimeMillis() * 1000L - (System.nanoTime() - captureNs) / 1000L); |
There was a problem hiding this comment.
At 1 FPS, a log emitted during the throttle wait can be attached to an image captured before that log. ScreenStreamer.onImageAvailable acquires the image before sleeping, then passes a fresh System.nanoTime() as captureNs after sleeping. writeFrame therefore stamps the image with the end of the wait rather than its capture time. PlaceLogs can assign messages emitted during that wait to the earlier image. Derive both frame timestamps from the image's capture time. Keep throttling timestamps separate.
🤖 Helpful? 👍/👎
|
|
||
| void DoRowsGUI(Rect list, int first, int end, Action<double> seek) | ||
| { | ||
| var content = new Rect(0, 0, list.width - kScrollbarWidth, m_Entries.Length * m_RowHeight); |
There was a problem hiding this comment.
With default columns, a preview narrower than 450 pixels hides every message's text. DoHeaderGUI assigns 450 pixels to columns before Message and clamps the remaining message width to zero. The capture list permits previews as narrow as 100 pixels. DoRowsGUI keeps its content narrower than the viewport, so horizontal scrolling cannot reveal the missing column. Give Message a minimum width. Size the scroll content to accommodate all columns. Scroll the header with the rows.
🤖 Helpful? 👍/👎
Purpose of PR
Type of change: Improvement to Video Capture
https://www.youtube.com/watch?v=yzMFgU90A94&feature=youtu.be
A recording can now also save the logcat messages logged while it runs, and when it plays back, the messages are listed under the video frame by frame. Stepping through a recording shows what the device logged at each moment.
Highlights
-v epoch -v usec, so frames and messages share one clock, to the microsecond..json, as alogslist on each entry offrameChanges.LogcatEntryis reused for this, and is now serializable, saving its time astimeUs.AndroidLogcatScreenshotInfois renamed toAndroidLogcatCaptureInfo, since it describes recordings too. Existing.jsonfiles load as before.DebugMethodsshows and logs typed characters, for testing keyboard input and logcat recording from the live view.Testing
LogsLandOnTheFrameTheyWereLoggedBeforeAndSurviveSavingin the recorder tests: placement of messages before, during and after the recording, and a JSON round trip.AndroidLogcatGeneralTestschecks the new setting is off by default and after Reset.Typed:message lands on the frame where the text changes.🤖 Generated with Claude Code