Repository navigation
Improve Capture Video window #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
1e3329b
WIP: recording
todi1856 01c3eef
Merge remote-tracking branch 'origin/master' into livestream-video
todi1856 9d4f02d
apply review fixes
todi1856 e39845f
try making seek
todi1856 9438fa1
fix seeking while paused
todi1856 147a375
fix play after seeking
todi1856 0bea531
remove length
todi1856 0dd55f1
don't start automatically
todi1856 5aa696c
use state changing
todi1856 a5b3cc7
add seeking by 1 frame
todi1856 5690249
still try to make see work
todi1856 5ef7377
tests
todi1856 0b8b944
fix tests
todi1856 627b507
split logic
todi1856 2a870c9
clear button
todi1856 86cb58d
fix seeking
todi1856 596cfaf
Add test recording for the video player tests
todi1856 9d58996
Use different name for video tests
todi1856 54b9034
remove
todi1856 abb254d
delete
todi1856 ff9ef31
remove m_PreviewIsVideo
todi1856 f042fc8
Flash video instead of switching to it
todi1856 46ed651
disable capture list while video is being taken
todi1856 adaf11f
Consolidate into AllocateCapturePath
todi1856 56c2e18
docs
todi1856 266f247
improve drag
todi1856 05efe53
apply review
todi1856 17ae9a1
add tests for 0 frame video
todi1856 28c7c57
fix tests
todi1856 5b19ccc
more fixes
todi1856 981d648
better comment
todi1856 f62f0e2
Add a way to manually capture recording
todi1856 b296dfe
show recording gui
todi1856 1250889
optmize recording
todi1856 6c9bdd8
switch to constant frametime
todi1856 71a2453
Support rotation
todi1856 1398c06
get rid of screenrecord and use static frames
todi1856 07da047
remove unused
todi1856 dfb177e
widen the box
todi1856 5ede199
show framerate
todi1856 f0fbd38
allow recordings of 60 fps
todi1856 f7e1b7e
add missing references
todi1856 a34f2c4
Add profiler markers
todi1856 b36b394
add UnityEngine.TypeRegistryModule
todi1856 84b7f69
add max recording time + handle script reload on recording
todi1856 d75215b
apply review
todi1856 5a1faba
fix
todi1856 3f779e8
tweak developer mode UI
todi1856 e2e050f
Preserve video/screenshot selection after domain reload
todi1856 1090ca4
Fix being stuck on domain reload
todi1856 e9da491
apply review
todi1856 62463fe
apply fixes
todi1856 e9f84ae
restore zoom after domain reload
todi1856 e301374
restore zoom for live view after domain reload
todi1856 e2cef57
Add context menu for zoom badge
todi1856 e407608
make badge more visible
todi1856 6fd7192
respect device rotation when recording
todi1856 63b06b9
Add ability to capture squared videos
todi1856 547e27d
record display changes
todi1856 54638bd
Clip video, respect display & content
todi1856 9148ea1
better tooltip for square video
todi1856 cc42acf
add record touches functionality
todi1856 8386b10
use different colors for touch actions
todi1856 af3a26e
apply fix with test
todi1856 0ca3b08
reformat
todi1856 502ef21
fixate width for details ui
todi1856 294f36a
update docs
todi1856 3e1b485
Try to fix static cleanup
todi1856 8dbe35d
Merge remote-tracking branch 'origin/master' into livestream-video
todi1856 47ed66b
apply review from Boris
todi1856 ef49aa0
optimize
todi1856 6b7c20b
fix hovering effect
todi1856 612929e
lock details ui, so it wouldn't switch between portrait and landscpae
todi1856 849ba75
always have build jar button present
todi1856 0feb030
Try to fix integration tests
todi1856 48db725
Revert "Try to fix integration tests"
todi1856 f24ab2b
Try to fix pause/resume
todi1856 6a50c09
Fix AndroidLogcatRuntimeIntegrationScreenCapture.CanRecordTheLiveStream
todi1856 481cc0e
Take Recording -> Start Recording
todi1856 3b6127d
remove unused images
todi1856 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,4 +23,5 @@ | |
| *.ttf binary | ||
| *.pdf binary | ||
| *.xcf binary | ||
| *.ico binary | ||
| *.ico binary | ||
| *.mp4 binary | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-142 KB
com.unity.mobile.android-logcat/Documentation~/images/capture_screenshot.png
Binary file not shown.
Binary file removed
BIN
-159 KB
com.unity.mobile.android-logcat/Documentation~/images/capture_video.png
Binary file not shown.
Binary file modified
BIN
-56.6 KB
(72%)
...mobile.android-logcat/Documentation~/images/device-screen-capture-live-view.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed
BIN
-2.21 KB
...e.android-logcat/Documentation~/images/device-screen-capture-window-toolbar.png
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 13 additions & 9 deletions
22
com.unity.mobile.android-logcat/Documentation~/screen-capture-video.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,26 @@ | ||
| # Capture a video | ||
|
|
||
| This page explains how to use the [Screen Capture tool](screen-capture.md) to capture a video of the connected device's screen and save it as a file on your computer. | ||
| This page explains how to use the [Screen Capture tool](screen-capture.md) to record the connected device's screen. | ||
|
|
||
| 1. Open the [Device Screen Capture window](screen-capture-window-reference.md). | ||
| 2. In the [Toolbar](screen-capture-window-reference.md#toolbar), use **Device Selector** to specify to device to take a screenshot of. | ||
| 3. Set **Screen Capture Mode** to **Video**. | ||
| 4. Select **Capture**. The Screen Capture tool begins to capture a video of the connected device's screen. | ||
| 5. When you want to finish the video, select **Stop**. The Screen Capture tool finishes capturing the video and displays it in the [Capture preview](screen-capture-window-reference.md#capture-preview). | ||
| 6. Select **Save As** and use the file explorer to save the video file to your computer. | ||
| 2. In the [Toolbar](screen-capture-window-reference.md#toolbar), use **Device Selector** to specify the device to record. | ||
| 3. Select **Live** in the [Capture list](screen-capture-window-reference.md#capture-list) to view the device's screen. | ||
| 4. Select **Start Recording** in the [Live view details](screen-capture-window-reference.md#live-view-details). The Screen Capture tool begins to record the device's screen, and the button becomes **Stop Recording**. | ||
| 5. Select **Stop Recording** to finish. The recording is added to the [Capture list](screen-capture-window-reference.md#capture-list), and its row is briefly highlighted. Select the row to open it in the [Capture preview](screen-capture-window-reference.md#capture-preview). The Capture list is disabled while recording. Closing the window also stops the recording. | ||
| 6. To keep a copy elsewhere, right-click the recording's row and select **Copy To...**. | ||
|
|
||
| Recordings are stored beside screenshots, in the folder set by [Captures Folder](android-logcat-settings.md#capture-settings), and are named `<device id>_<number>.mp4`. | ||
|
|
||
| A recording is made from the live view, so it shows the view as it is turned. The video is square, as wide and tall as the longest side of the stream, so turning the device, or unfolding a foldable, keeps the picture at full size. The rest of the square is black. To record at the size of the screen instead, disable **Square Video** in the [Recording settings](android-logcat-settings.md#recording). To record at a larger size or a higher quality, raise **Max Size** and **JPEG Quality** in the [Live Stream settings](android-logcat-settings.md#live-stream). Recordings play at the **Max Frame Rate** of the Live Stream settings, 30 frames per second by default. A higher rate records fast movement more smoothly, but costs more Editor time, and at a large **Max Size** the device may not deliver frames that fast. The device only sends a frame when its screen changes, so while the screen is still, the recording repeats the last frame. A recording stops on its own after the **Time Limit** in the [Recording settings](android-logcat-settings.md#recording), 10 minutes by default. It also stops, and is saved, when Unity reloads scripts, for example after a script is changed. | ||
|
todi1856 marked this conversation as resolved.
Resolved
|
||
|
|
||
| ## Details | ||
|
todi1856 marked this conversation as resolved.
Resolved
|
||
|
|
||
| * When recording a video, the Screen Recorder Tool doesn't capture sound. | ||
| * The Screen Recorder Tool uses Unity's video player for the video preview. If your operating system is Windows, you might see `WindowsVideoMedia` warnings in the Editor console. This is because the video is not processed. | ||
| * If the entire video contains a static image, the video only contains one frame and the length of the video will be zero. | ||
| * Recording uses the Editor to encode the video, which takes some of its time while a recording runs. A larger stream costs more. | ||
|
todi1856 marked this conversation as resolved.
Resolved
|
||
| * The Linux Editor can't record, or play recordings back, because it doesn't support H.264 video. | ||
| * On Chrome OS, you can only capture the video from the sandboxed app which is the one you install manually via adb or Unity. You can't capture video from the desktop or from built-in apps. | ||
|
|
||
| ## Additional resources | ||
|
|
||
| * [Device Screen Capture window reference](screen-capture-window-reference.md) | ||
| * [Capture a screenshot](screen-capture-screenshot.md) | ||
| * [Capture a screenshot](screen-capture-screenshot.md) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.