Repository navigation
Improve Capture Video window - #229
Conversation
There was a problem hiding this comment.
💡 Harness Review
The change unifies screenshots and recordings in the live capture workflow, but the recording lifecycle and shared file operations need corrections.
Renaming a recording changes its extension to .png, so the capture preview can no longer play it. The newly listed recordings use RenameScreenshot, which constructs the destination with GetImageExtension() rather than preserving the source extension. SyncPreview then sends the renamed MP4 bytes to Texture2D.LoadImage because IsVideo returns false. Construct the destination with Path.GetExtension(path). Use that extension in the collision message.
Reviewed commit 01c3eef
🤖 Helpful? 👍/👎
A screenrecord capture with a variable frame rate and a single keyframe, which AndroidLogcatVideoPlayerTests play, step and seek through. Marked binary in .gitattributes, which otherwise normalizes every file as text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
/review |
|
/review |
There was a problem hiding this comment.
💡 Harness Review
The change replaces device-side recording with live-stream encoding and adds playback controls and selection restoration. I examined recording timing, preview behavior, capture operations, and lifecycle handling, and found no new issues beyond those previously reported.
Reviewed commit af3a26e
🤖 Helpful? 👍/👎
BorisShir
left a comment
There was a problem hiding this comment.
Few minor comments, feel free to ignore.
IMO, testing on MacOS is also required.
This reverts commit 0feb030. The Bokken token was restored, and connecting on a fixed port did not help. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
IGuscin
left a comment
There was a problem hiding this comment.
Looks good, thanks for an awesome improvement.
Tested on both Windows 11 and Mac 27.2.1, U6.0, 6.3, trunk.
Tomas addressed couple small issues I've noticed, so good to land.
anjalin14
left a comment
There was a problem hiding this comment.
Approving with a few suggestions. Thank you!
Purpose of PR
Type of change: Improvement to Video Capture
https://jira.unity3d.com/browse/PLAT-23512
Screen recordings in the Screen Capture window are now made from the live stream, and can be played back in the window.
https://www.youtube.com/watch?v=exqVXgTFjNU&feature=youtu.be
Highlights
UnityEditor.Media.MediaEncoder, replacingadb screenrecord.dumpsys display..json, asframeChangesover time:AndroidLogcat.*) for the recording and live stream hot paths.Halo effect
Screen Capture window: live view, capture list, screenshots.
adb screenrecordis no longer used. Linux has no H.264 encoder or player, so recording and playback are unavailable there, and the video tests are skipped.Testing status
AndroidLogcatVideoPlayerTests. Test videos are generated at test time withMediaEncoder. They cover opening, play/pause, stepping, seeking while paused and while playing, resuming, single-frame videos, and rename/delete of the previewed recording.AndroidLogcatStreamRecorderTests: frame changes of frames still queued keep their time after a later touch.CanRecordTheLiveStream,RecordingNeedsTheLiveStream).🤖 Generated with Claude Code