bugfix(pathfinder): Fix rare retail pathfinding crashes in forwardInsertionSortRetailCompatible() and putOnClosedList() - #3113
Open
Mauller wants to merge 2 commits into
Conversation
Mauller
force-pushed
the
Mauller/fix-retail-pathfinder-crashes
branch
2 times, most recently
from
August 11, 2026 21:24
a201f76 to
4679cb1
Compare
Author
|
Just a small wording tweak that i noticed. |
Mauller
changed the title
Caball009
reviewed
Aug 11, 2026
bobtista
reviewed
Aug 11, 2026
| @@ -1727,6 +1727,15 @@ void PathfindCell::forwardInsertionSortRetailCompatible(PathfindCellList& list) | |||
| UnsignedInt cellCount = 0; | |||
| while (currentCell && cellCount < PATHFIND_CELLS_PER_FRAME && currentCell->m_info->m_totalCost <= m_info->m_totalCost) | |||
There was a problem hiding this comment.
can currentCell->m_info be null here?
Author
There was a problem hiding this comment.
Not in the way you are likely thinking.
When cells are initially put onto the list they are externally checked to make sure they have info allocated to them first.
The only time it crashes at this point is if a cell initially put onto the list has dangling next pointers.
bobtista
reviewed
Aug 11, 2026
| while (currentCell && cellCount < PATHFIND_CELLS_PER_FRAME && currentCell->m_info->m_totalCost <= m_info->m_totalCost) | ||
| { | ||
| // Prevent a retail crash where a pathfindCell has an m_info with a dangling nextOpen pointer | ||
| if (currentCell->m_info->m_nextOpen && !currentCell->m_info->m_nextOpen->m_cell->m_info) { |
Author
There was a problem hiding this comment.
Normally when these cell infos have dangling pointers it tends to be present.
bobtista
reviewed
Aug 11, 2026
Caball009
self-requested a review
August 12, 2026 18:32
Mauller
force-pushed
the
Mauller/fix-retail-pathfinder-crashes
branch
2 times, most recently
from
August 12, 2026 18:36
4ddc8a3 to
ee6c4f5
Compare
xezon
approved these changes
Aug 12, 2026
Caball009
reviewed
Aug 13, 2026
Caball009
requested changes
Aug 13, 2026
There was a problem hiding this comment.
I want to do some testing before this gets merged.
Edit: just so I don't lose track of the desired changes:
- Removal of the failover code for these fixes because they're not necessary for the (VC6) replays.
- Attaching the VS22 reproduction replays & custom map to the PR description.
- Changes to function
Pathfinder::forceCleanCellsimproving the printing.
…ed list has no associated m_info (#3113)
Mauller
force-pushed
the
Mauller/fix-retail-pathfinder-crashes
branch
from
August 13, 2026 19:19
ee6c4f5 to
dbc8b9d
Compare
Author
|
Made updates to remove the failover and cleanup flags, they weren't necessary. The only reason the reproduction replays were mismatching is due to code Cabal had added to get past the crash point. |
… dangling linked list pointer (#3113)
Mauller
force-pushed
the
Mauller/fix-retail-pathfinder-crashes
branch
from
August 13, 2026 19:43
dbc8b9d to
c0fc2b6
Compare
Caball009
approved these changes
Aug 13, 2026
Caball009
left a comment
Caball009
left a comment
There was a problem hiding this comment.
Nice to see these pathfinding crashes fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2799
Closes: #2637
This PR fixes a recently discovered, but rarer to happen, pair of retail pathfinding crashes.
These crashes do not occur in the non-retail crash-fixed pathfinding.
The crash in putOnClosedList() occurs due to a pathfinding cell being placed onto the closed list without an associated pathfindCellinfo.
The retail insertion sort crash occurs for a similar reason, a cell placed onto the list contains a pathfind info that has a dangling nextOpen pointer to another cell info that is malformed.
EDIT: Made a small addition to add an extra bit of requested debug output, the failover message now also mentions the frame the failover occurred.
Map and reproduction replays compatible with Visual Studio builds
Note that these replays will mismatch at the crash point due to inital crash catch and prevention code during replay capture.
Replays: pathfinding_crash_repros.zip