bugfix(map): Write and scan the map cache with the platform separator - #3107
Draft
bobtista wants to merge 4 commits into
Draft
bugfix(map): Write and scan the map cache with the platform separator#3107bobtista wants to merge 4 commits into
bobtista wants to merge 4 commits into
Conversation
bobtista
force-pushed
the
bobtista/bugfix/map-cache-separator
branch
from
August 14, 2026 12:00
c92a408 to
242bf48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeCacheINIdoesfilepath.concat('\\')before appending the file name, andloadMapsFromMapCacheINIandloadMapsFromDiskbuild their paths the same way. Off Windows that character lands inside the file name:Now all three go through
getPathInDirectoryandgetLastPathSeparator, so the cache is written where it is read from and the map path shape is checked against whichever separator the listing actually used.INIMapCachereads that same cache, and built the fallback display name for maps without a localized name tag withname.reverseFind('\\') + 1. With no backslash in the name that isnullptr + 1. Now it reads the leaf throughgetLastPathSeparator, the same guard applied to theMapUtilfallback in #3106.Todo: