unify(shell): Move Shell to Core - #3070
Open
Jaredl-Dev wants to merge 2 commits into
Open
Conversation
Jaredl-Dev
added a commit
to Jaredl-Dev/GeneralsGameCode
that referenced
this pull request
Aug 7, 2026
Jaredl-Dev
added a commit
to Jaredl-Dev/GeneralsGameCode
that referenced
this pull request
Aug 7, 2026
Jaredl-Dev
added a commit
to Jaredl-Dev/GeneralsGameCode
that referenced
this pull request
Aug 7, 2026
Jaredl-Dev
added a commit
to Jaredl-Dev/GeneralsGameCode
that referenced
this pull request
Aug 7, 2026
Author
|
Generals now inherits |
Jaredl-Dev
added a commit
to Jaredl-Dev/GeneralsGameCode
that referenced
this pull request
Aug 8, 2026
Jaredl-Dev
added a commit
to Jaredl-Dev/GeneralsGameCode
that referenced
this pull request
Aug 8, 2026
Author
|
I've revised this PR and updated the body to reflect the changes. Please also review my question above. |
xezon
reviewed
Aug 9, 2026
Jaredl-Dev
added a commit
to Jaredl-Dev/GeneralsGameCode
that referenced
this pull request
Aug 13, 2026
Jaredl-Dev
force-pushed
the
unify/shell
branch
from
August 13, 2026 20:07
1d17f98 to
d7b3934
Compare
Jaredl-Dev
added a commit
to Jaredl-Dev/GeneralsGameCode
that referenced
this pull request
Aug 13, 2026
xezon
reviewed
Aug 13, 2026
Jaredl-Dev
force-pushed
the
unify/shell
branch
from
August 13, 2026 21:28
d7b3934 to
94e9145
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges the shared Shell implementation and moves it into Core:
Shell.hShell.cppShellHooks.hShellMenuScheme.hShellMenuScheme.cppBefore this change, Generals and Zero Hour differed only by product-name comments and the
RTS_PROFILE_LEGACYinitialization profiling hook inShell.cpp.Generals gets
initprofiling range before opening the main menu, matching Zero Hour.Dependency cleanup
Because profile builds of the shared Shell call
Profile::StopRange("init"):core_profile_legacythroughcorei_gameengine_private.core_profile_legacyprivately linkscore_debug.Verification