fix: editor grid placement, block settings validation and public API issues - #17
Merged
Merged
Conversation
…issues - Resizing keeps the block in place, repacks neighbours with vertical compaction; dropping onto a same-size block swaps them; all moved blocks animate (was: jump to the first free cell in column 0) - Allow empty text blocks, language count as a 3-8 select, length limits on text and username inputs - Stack legacy blocks without a layout by order instead of row 0 - Exact GitHub language bytes via GraphQL when GITHUB_TOKEN is set - Separate, higher rate limit for public SVG images (camo proxy) - Hide userId from the public widget payload - Drop unused width/height from widget create/update
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editor grid (reported bug). Resizing a block used
findPlacement, which on any collision moved the block to the first free cell scanning down column 0 — e.g. growing the top-right block to 1×2 threw it under the left column. Now:Block settings. Clearing a text block or typing an out-of-range language count made autosave fail with a raw zod message. Empty text is now valid (renderers show the default text, as the editor already did), the language count is a 3–8 select, text/username inputs have length limits.
Other fixes
GITHUB_TOKENis set (was: each repo's whole size credited to its primary language, first 100 repos only). REST approximation remains without a token.userId.width/heightfrom widget create/update schemas.Test plan
userIdhidden, SVG vs JSON limits (server)format:check,lint,typecheck,test(36 client + 34 server),build,typecheck:api