feat: account page with Yandex linking, and 404/500 pages - #18
Merged
Merged
Conversation
- /account lists sign-in methods; connect Yandex ID via /api/auth/yandex?intent=link (intent bound to the OAuth state, user identified by the refresh cookie), disconnect only if a password remains - /api/auth/me returns sign-in methods - ErrorPage (widgets/error-page) for unknown routes, missing public widgets, failed editor loads, plus an app-level error boundary - Unconfigured Yandex redirects back to the app instead of JSON 503 - Vitest inlines Gravity UI so components importing its CSS are testable
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
4 tasks done
…account-linking # Conflicts: # CHANGELOG.md
TheGeniusOfEternity
deleted the
feat/error-pages-and-account-linking
branch
September 29, 2026 19:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent of #17 (both based on
main); expect a smallCHANGELOG.mdconflict for whichever merges second.Summary
Account linking (step 3 of the Yandex sign-in design: accounts are keyed by
yandexId, email clashes are refused, linking is an explicit action by a signed-in user)./accountpage (sidebar → "Account") with sign-in methods: email/password and Yandex ID.GET /api/auth/yandex?intent=link. The intent is stored together with the OAuth state (link:<state>cookie), so it can't be swapped on the way back; the callback identifies the user by their refresh cookie (path/api/auth) and attaches the Yandex id unless another account already owns it. Results come back as/account?linked=yandexor?link_error=….DELETE /api/auth/yandex, refused with 409 when Yandex is the only sign-in method./api/auth/menow also returnsmethods: { password, yandex }.Error pages
widgets/error-page/ErrorPagefor 404/500, used for unknown routes (previously silently showed the landing), missing or unpublished public widgets, and failed editor loads (404 vs 500 by status, with retry).Tests
@gravity-ui/*so components that import its CSS can be tested.Test plan
/definitely-missingand/w/no-such-widgetshow 404; sidebar → Account shows methods with "Connect" for Yandexformat:check,lint,typecheck,test(37 client + 34 server),build,typecheck:apiNote: I saw one unreproducible failure of
rateLimit.test.tsright after a bulk file rewrite; 10 reruns were green.