Repository navigation
[5/11] feat(settings): a brighter outline on the hero - #216
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
area:player
github-actions
Bot
added
area:art
arudaev
changed the title
arudaev
changed the title
arudaev
changed the title
arudaev
force-pushed
the
playtest/5-hero-outline
branch
from
October 25, 2026 10:23
5263817 to
b9cea42
Compare
Playtest R1: the grey/blue/teal poncho blends into the autumn scenery. Settings -> Hero swaps the actors' warm rim for a brighter cool one on the hero, at once and saved in the browser. The poncho colour itself stays Alexander's decision. Refs #159
… decision Playtest R1: the THD poncho, a white one and a purple one on the hero at game size in front of the garden's leaves. A quick recolour to decide from, not final art: the chosen colour gets redrawn from the hero sheet. Refs #159
arudaev
force-pushed
the
playtest/5-hero-outline
branch
from
October 25, 2026 11:57
b9cea42 to
9dcf079
Compare
arudaev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: 5 of 11 (playtest): base #215. Merge bottom-up, only on Alexander's word.
What and why
Playtest R1 (Vatsal, A15): the hero blends into the trees and the tree line, because the grey/blue/teal THD poncho sits in the same values as the autumn scenery. The colour is "something for Alex to decide", so this PR doesn't change the poncho. It adds the quick fix the checklist names as a setting:
ACTOR_RIM0.45) for a cool white one at 0.95 on the hero and the hero's slices. It applies at once (the player listens to the store).core/preferences.ts,deggster.preferences). A broken or blocked storage just means the default.For the colour decision (second commit): the hero in the THD poncho, a white one and a purple one (the playtesters' two suggestions) on the garden path at game size. This is a quick recolour to decide from; the chosen colour gets redrawn from the hero sheet with gpt-image-2.5.
Purple separates most from the autumn leaves. White helps less, because the path and the leaves' highlights are pale too.
Issue
Refs #159 (readability), #72 (playtest checklist R1: the quick fix 🔧, the colour still ❓)
Verification
npm test: 335 passed (3 new inpreferences.test.ts: default, saved and announced, broken data, the rim choice);tscclean;check_docsclean.{"heroOutline":true}with no errors.