Skip to content

Bump rqt_robot_monitor for Qt6 - #235

Merged
Tobias-Fischer merged 2 commits into
RoboStack:mainfrom
nobleo:fix-lyrical-rqt-robot-monitor-qt6
Nov 20, 2026
Merged

Tobias-Fischer merged 2 commits into
RoboStack:mainfrom
nobleo:fix-lyrical-rqt-robot-monitor-qt6

Conversation

@Timple

@Timple Timple commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Tobias-Fischer

Copy link
Copy Markdown
Collaborator

Don't we need to bump the version? Currently this doesn't do anything, does it?

@Timple

Timple commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Whups, there is no new version yet. I could pin to 334e1e1bd38921f76f5a015cf758e6d0d9d45c5f

Is there already an ABI-checker in place? Otherwise it only works with the new mutex right?

Tobias-Fischer added a commit that referenced this pull request Nov 20, 2026
testpr.yaml's abi-comment job was skipped for pull requests from forks, whose
runs only get a read-only token (e.g. #235). Post the comment from a separate
workflow_run workflow instead, which runs from main with a write token, for all
pull requests.

It never checks out or runs pull-request code: the abi-check-*.md artifacts
and the branch name come from the pull request's run, so they are only used as
the comment text, and the pull request is looked up from the API (open, head at
the built commit) rather than taken from the artifacts. A cancelled run (a newer
push) posts nothing.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

ABI check (linux-64)

lyrical linux-64: 1 can be bumped on their own
1 packages can be bumped on their own (no libraries: 1)
package released → PR verdict details
rqt-robot-monitor 1.0.6 (build 30) → 1.0.7 no libraries: nothing to compare pins changed: python_abi 3.12.* _cp312 → 3.14. *_cp314

Compared with the newest builds on https://repo.prefix.dev/robostack-lyrical/linux-64.

About this check

Each package this pull request built, compared with its newest released build (tools/abi_check.py, libabigail):

  • compatible / additions: the package can be bumped on its own;
  • soname / incompatible: the packages that depend on it need a rebuild (build number bump) in the same pull request.

Exported symbols are compared (the released packages are stripped, so struct layouts aren't); unchanged installed headers rule out layout and inline changes, changed ones are listed for review. Dependents to rebuild are the released ones linking to a changed library. A changed pin is part of the comparison.

@Tobias-Fischer
Tobias-Fischer merged commit b10cd06 into RoboStack:main Nov 20, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants