Skip to content

abi_check: compare with the released build of the same variant - #241

Merged
Tobias-Fischer merged 1 commit into
mainfrom
abi-check-variant
Nov 20, 2026
Merged

Tobias-Fischer merged 1 commit into
mainfrom
abi-check-variant

Conversation

@Tobias-Fischer

Copy link
Copy Markdown
Collaborator

The ABI check compared each PR build with one released build per version: whichever was uploaded last. Most versions are published as several builds with the same build number (on lyrical linux-64, 1253 of 1940 versions: one per Python version), so the comparison could pick a different variant. In #235 a Python 3.14 build of rqt-robot-monitor was compared with the 3.12 one and reported pins changed: python_abi 3.12 → 3.14; for a compiled package it would compare libraries built against different Pythons.

released() now keeps every build of a version's newest build number (variants), and check_pr_builds compares with matching_variant(): the same python_abi, then the most identical dependencies, then the newest upload.

Checked against the lyrical channel: for rqt-robot-monitor a py314 build now gets np2py314h53a0733_30, a py312 build np2py312h1bab3cf_30. pixi run rs check passes.

🤖 Generated with Claude Code

A package version is often published as several builds with the same build
number, e.g. one per Python version. released() kept only the newest upload,
so a Python 3.14 PR build could be compared with the Python 3.12 release
(reported as a python_abi pin change, and for compiled packages a comparison
of libraries built against different Pythons). Keep every build of the newest
build number and compare with the one built like the PR's: the same
python_abi, then the most identical dependencies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Tobias-Fischer Tobias-Fischer added the build:none PR build: build no packages, only run the checks (tooling, CI or docs changes) label Nov 20, 2026
@Tobias-Fischer
Tobias-Fischer enabled auto-merge (squash) November 20, 2026 21:32
@Tobias-Fischer
Tobias-Fischer merged commit 0ec838a into main Nov 20, 2026
7 checks passed
@Tobias-Fischer
Tobias-Fischer deleted the abi-check-variant branch November 20, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build:none PR build: build no packages, only run the checks (tooling, CI or docs changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant