Repository navigation
abi_check: compare with the released build of the same variant - #241
Merged
Merged
Conversation
A package version is often published as several builds with the same build number, e.g. one per Python version. released() kept only the newest upload, so a Python 3.14 PR build could be compared with the Python 3.12 release (reported as a python_abi pin change, and for compiled packages a comparison of libraries built against different Pythons). Keep every build of the newest build number and compare with the one built like the PR's: the same python_abi, then the most identical dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tobias-Fischer
enabled auto-merge (squash)
November 20, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ABI check compared each PR build with one released build per version: whichever was uploaded last. Most versions are published as several builds with the same build number (on lyrical linux-64, 1253 of 1940 versions: one per Python version), so the comparison could pick a different variant. In #235 a Python 3.14 build of
rqt-robot-monitorwas compared with the 3.12 one and reportedpins changed: python_abi 3.12 → 3.14; for a compiled package it would compare libraries built against different Pythons.released()now keeps every build of a version's newest build number (variants), andcheck_pr_buildscompares withmatching_variant(): the samepython_abi, then the most identical dependencies, then the newest upload.Checked against the lyrical channel: for
rqt-robot-monitora py314 build now getsnp2py314h53a0733_30, a py312 buildnp2py312h1bab3cf_30.pixi run rs checkpasses.🤖 Generated with Claude Code