Repository navigation
refactor(lightning)!: remove MultiloaderLifecycle, it lives in ratiopath - #13
Merged
Merged
Conversation
The callback moved to ratiopath 1.5.0 (ratiopath[lightning]). mlkit keeps the old import paths as a re-export, so projects that import it from mlkit keep working and get the same class.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
matejpekar
requested changes
Oct 20, 2026
matejpekar
left a comment
matejpekar
left a comment
Member
There was a problem hiding this comment.
I would completely remove the definition of MultiloaderLifecycle from mlkit. Reexporting it from ratiopath is weird.
The callback moved to ratiopath 1.5.0 (ratiopath.lightning.callbacks). mlkit no longer defines or re-exports it; the rationai.mlkit.lightning.callbacks package is removed. mlkit requires ratiopath>=1.5.0, so every mlkit environment already has the class under its new import path. BREAKING CHANGE: import MultiloaderLifecycle from ratiopath.lightning.callbacks.
vejtek
changed the title
Adames4
approved these changes
Oct 21, 2026
matejpekar
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callback moved to ratiopath in RationAI/ratiopath#56 and was released in ratiopath 1.5.0. Following @matejpekar's review, mlkit no longer defines or re-exports it.
rationai.mlkit.lightning.callbackspackage is removed (it contained onlyMultiloaderLifecycle). Breaking change: import it asfrom ratiopath.lightning.callbacks import MultiloaderLifecycle.ratiopath>=1.4.2→ratiopath>=1.5.0, without thelightningextra (mlkit depends onlightningdirectly). Every mlkit environment therefore has the class under its new import path.uv.lockupdated (ratiopath 1.4.2 → 1.5.0).masteralready reports 18 errors; this PR only removes code.Known users of the old import path:
carcinoma-binary-classification-methods(7 callbacks; itsuv.lockpins an older mlkit, so nothing breaks until it upgrades; its maintainer gets a note on Slack) andstain-normalization(still on the archived GitLab mlkit 0.3.1, unaffected).DEV-161. Prepared by Claude for @vejtek; not merged by the agent.