Repository navigation
fix: prepare canonical optional AI dependency identity - #719
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lifecycle report already prints its findings, then deliberately fails on strict/warning repositories. Its identity step only reads CN research and uses an old alias directory for the canonical remote, so QSP's existing optional ai dependency remains unmanaged.
Read the existing QSP ai and CN research inputs, require one full matching manifest/lock/declaration pin with optional-only proof, and prepare a canonical QuantAIService identity checkout. Preserve the strict gate, scopes, token expression, permissions, concurrency and frozen workspace behavior; no checker, bundle, registry or managed allowlist changes. The checkout must retain the approved origin and non-runtime ops/tooling identity.
Validation: 44 local QSL unit methods pass (30 subcases recorded separately), actionlint and bash syntax pass. Four offline stages use the actual QSP metadata bytes: original and either single-repo intermediate remain strict; the combined candidate is clean. Clone/checkout/HEAD are synthetic in tests; no dependency install, provider call or deployment was performed locally.
Companion: QuantStrategyLab/QuantStrategyPlugins#90 canonicalizes four repository literals while preserving package ai-gateway-client, optional ai and pin 65c8bcf432f578f657c12d5dab0e16ebec0bef5a. After independent review, adopt this QRS support before the companion metadata. This PR is a draft pending that review; no merge or workflow dispatch/rerun.