Skip to content

[likelihood_bayes] Update lecture according to the style guide - #651

Merged
jstac merged 5 commits into
mainfrom
likelihood-bayes-fix
Aug 5, 2026
Merged

[likelihood_bayes] Update lecture according to the style guide#651
jstac merged 5 commits into
mainfrom
likelihood-bayes-fix

Conversation

@HumphreyYang

@HumphreyYang HumphreyYang commented Oct 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This PR corrects some notations and update likelihood_bayes according to the style guide.

@github-actions

github-actions Bot commented Oct 21, 2025

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-651--sunny-cactus-210e3e.netlify.app (af66993)

📚 Changed Lecture Pages: likelihood_bayes

@HumphreyYang
HumphreyYang marked this pull request as ready for review October 28, 2025 23:10
@HumphreyYang
HumphreyYang requested a review from mmcky October 28, 2025 23:10
@github-actions

github-actions Bot commented Oct 29, 2025

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-651--sunny-cactus-210e3e.netlify.app (d0f515f)

📚 Changed Lecture Pages: likelihood_bayes, likelihood_ratio_process, likelihood_ratio_process_2

@jstac

jstac commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🤖 Status note for a future session — from a maintainer investigation on 2026-07-08 into why open-PR previews 404. Context only, not instructions.

Netlify preview: https://pr-651--sunny-cactus-210e3e.netlify.app/ currently returns 404.

Why previews are down (repo-wide findings)

1. This branch is stale — 164 commits behind main. A preview build compiles the whole site from this branch. This branch's lectures/house_auction.md still has unpinned !pip install prettytable, which now breaks on a wcwidth incompatibility. main fixed this on 2026-06-28 by pinning prettytable<3.18 (#939). This alone fails any rebuild of this branch until it's updated to main.

2. The arviz failure was a red herring — do NOT pin arviz or rewrite plotting. A 2026-07-07 rebuild also failed in ar1_bayes/ar1_turningpts with an arviz_plots figsize ValueError. That was a transient bug in an intermediate arviz-plots 1.x release, already fixed in arviz 1.2.0. Verified locally on a clean latest-stack venv: the real az.plot_trace(trace) cell (pymc + numpyro InferenceData) runs green. The lectures use only 1.x-compatible arviz APIs (plot_trace, summary, from_numpyro, compare).

Recommended first step for this PR

Update this branch to main (merge or rebase — pulls in #939 plus ~164 other commits), then let CI rebuild. On today's latest libraries the site builds clean, so the preview should return. house_auction is the known blocker; updating also picks up other since-merged fixes — rebuild and address any remaining per-lecture failures. Verify with:

curl -sI https://pr-651--sunny-cactus-210e3e.netlify.app/likelihood_bayes.html

This PR touches: likelihood_bayes.md, likelihood_ratio_process.md, likelihood_ratio_process_2.md. Last CI build: success@2025-10-29. Branch: 164 commits behind main as of 2026-07-08.

@Chihiro2000GitHub Chihiro2000GitHub mentioned this pull request Jul 25, 2026
Merged
@jstac
Merge branch 'main' into likelihood-bayes-fix
630ff6d 
Brings the branch up to date after 216 commits, keeping main's later work
on these files: the emphasis-vs-definitions fix in #723 and the
default_rng migrations in #976 and #991.

Also restores bold on "likelihood ratio process" at the point where it is
defined. The style guide reserves bold for definitions and italic for
emphasis, so the de-emphasis in this branch was right everywhere except
the one sentence that actually gives the definition.
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

📖 Netlify Preview Ready!

Preview URL: https://pr-651--sunny-cactus-210e3e.netlify.app

Commit: 630ff6d

📚 Changed Lectures

Build Info

@jstac
jstac merged commit 07975d5 into main Aug 5, 2026
2 checks passed
@jstac
jstac deleted the likelihood-bayes-fix branch August 5, 2026 10:05
@mmcky mmcky mentioned this pull request Aug 5, 2026
Open
@mmcky

mmcky commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

✅ Translation sync completed (zh-cn)

Target repo: QuantEcon/lecture-python.zh-cn
Translation PR: QuantEcon/lecture-python.zh-cn#240
Files synced (3):

  • lectures/likelihood_bayes.md
  • lectures/likelihood_ratio_process.md
  • lectures/likelihood_ratio_process_2.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmcky mmcky Awaiting requested review from mmcky

Assignees

No one assigned

Labels

lecture review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HumphreyYang @jstac @mmcky