Repository navigation
chore(deps): bump react and @types/react in /app - #527
dependabot[bot] wants to merge 2 commits into
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f3f84b5dc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "react": "^19.3.1", | ||
| "react-dom": "^18.3.1" |
There was a problem hiding this comment.
When Electron loads renderer/src/main.tsx, createRoot comes from React DOM 18 while components use React 19. The lockfile confirms that react-dom@18.3.1 supports only the react@^18.3.1 peer, and npm ci reports the incompatible pairing; the matching type packages are likewise split across majors. This can break renderer startup and hook execution, so upgrade react-dom and @types/react-dom to matching 19.x versions or keep React on 18.x.
Useful? React with 👍 / 👎.
d2f863d to
dc0e260
Compare
Bumps [react](https://github.com/react/react/tree/HEAD/packages/react) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together. Updates `react` from 18.3.1 to 19.3.1 - [Release notes](https://github.com/react/react/releases) - [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/react/react/commits/v19.3.1/packages/react) Updates `@types/react` from 18.3.31 to 19.3.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-version: 19.3.0 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: react dependency-version: 19.3.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dc0e260 to
027f08e
Compare
…to 19.3.x (companion to the react/@types/react bump; resolves the ERESOLVE @types/react@19 vs @types/react-dom@18 conflict)
|
@dependabot rebase |
Bumps react and @types/react. These dependencies needed to be updated together.
Updates
reactfrom 18.3.1 to 19.3.1Release notes
Sourced from react's releases.
... (truncated)
Changelog
Sourced from react's changelog.
... (truncated)
Commits
61aa00d[19.3.x][Flight] Improve transport protocol (#37845)2dc7da7[test] Bump Jest to 30.4 (#37382)4f93894docs: remove stale parentType param from validateChildKeys JSDoc (#36928)dbc3750Update required references to GitHub repo (#36752)900ae09[flow] Bump flow to v0.317.0 (#36701)fbb1370[flow] Bump flow to v0.307.1 (#36199)56922cf[react-native-renderer] Delete Paper (legacy) renderer (#36285)74568e8[Flight] TransportAggregateErrors.errors(#36156)e66ef64[tests] remove withoutStack from assertConsole helpers (#35498)db71391[Fiber] Instrument the lazy initializer thenable in all cases (#35521)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react since your current version.
Updates
@types/reactfrom 18.3.31 to 19.3.0Commits