Repository navigation
chore(deps): bump react-dom and @types/react-dom in /app - #529
dependabot[bot] wants to merge 1 commit into
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be3442933c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "electron-updater": "^6.8.11", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1" | ||
| "react-dom": "^19.3.1" |
There was a problem hiding this comment.
Keep React and React DOM on the same major
When the renderer imports react-dom/client, this installs React DOM 19.3.1 alongside React 18.3.1; the new React DOM package explicitly requires React ^19.3.1, and its runtime version guard rejects the mismatched React version before the application can mount. The type packages have the same mismatch (@types/react-dom 19 requires @types/react 19), producing peer-resolution problems during the required quality workflow. Upgrade React and its types together, or keep both DOM packages on 18.x.
AGENTS.md reference: AGENTS.md:L3-L4
Useful? React with 👍 / 👎.
7421764 to
e900b28
Compare
Bumps [react-dom](https://github.com/react/react/tree/HEAD/packages/react-dom) and [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom). These dependencies needed to be updated together. Updates `react-dom` from 18.3.1 to 19.3.1 - [Release notes](https://github.com/react/react/releases) - [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/react/react/commits/v19.3.1/packages/react-dom) Updates `@types/react-dom` from 18.3.7 to 19.3.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-version: 19.3.0 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: react-dom dependency-version: 19.3.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
e900b28 to
693d81d
Compare
|
Superseded by #527 — the react-dom/@types/react-dom bump is folded into the coherent React 19 bump (the two majors must land together or npm ERESOLVEs). owner-directed automation. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps react-dom and @types/react-dom. These dependencies needed to be updated together.
Updates
react-domfrom 18.3.1 to 19.3.1Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
61aa00d[19.3.x][Flight] Improve transport protocol (#37845)f4e439e[Fizz] Addnonceto renderedimport maps(#37339)21c89c9[DOM] Clean up Fragment listeners on signal abort (#37457)065bc84[DOM] Unobserve fragment IntersectionObserver targets after exit (#37408)ff7445e[DOM] Update HTML parser rules for new select parser (#34804)2dc7da7[test] Bump Jest to 30.4 (#37382)29d9d31[DOM] Copysourceonto the synthetic toggle event (#37389)269bd40[test] Remove the customtoThrowoverride for legacy V8 error messages (#37...a112448[DOM] Treat omitted Fragment Event listener options same ascapture: false...3d05080[Fizz] Construct the render lifetime controller only when it is needed (#37357)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react-dom since your current version.
Updates
@types/react-domfrom 18.3.7 to 19.3.0Commits