Add test/build: extension-metadata tests + raw SQL syntax checks

[jnasbyupgrade]

Summary

Adds test/build, using pgxntool's existing PGXNTOOL_ENABLE_TEST_BUILD feature (this repo never had a test/build directory before), and removes test/sql/install.sql, whose packaging checks it makes redundant.

1. Remove test/sql/install.sql

Tested extension packaging (dependency declarations, clean install/uninstall) rather than test_factory's actual business logic. Deleted outright, along with the leading dependency-check block it left in test/sql/pgtap.sql (the rest of that file, which exercises tf.tap(), is untouched).

2. Add test/build/syntax.sql

Runs sql/test_factory.sql and sql/test_factory_pgtap.sql -- the actual source files a developer edits -- directly via \i (not CREATE EXTENSION), so a genuine syntax error is reported clearly instead of being obscured by a generic CREATE EXTENSION failure. Deliberately not the pgxntool-generated, version-suffixed copies of these files (sql/*--VERSION.sql): confirmed those are byte-identical except for one auto-generated header line, so there's no reason to resolve a version number here at all.

Known/expected errors baked into its expected output (documented in the file itself):

• Two pg_extension_config_dump() can only be called from an SQL script executed by CREATE EXTENSION errors -- that function always errors when its containing script is \i'd directly instead of run via CREATE/ALTER EXTENSION, regardless of whether the SQL is otherwise valid.
• A handful of NOTICE: type reference ... converted to text lines, harmless artifacts of the same bare-execution path.

ON_ERROR_ROLLBACK savepoints each statement so those expected errors don't abort the rest of the file, while a real syntax error still surfaces clearly on its own. VERBOSITY is knocked down from psql.sql's verbose to default since the verbose LOCATION line differs across PG majors, which would otherwise break matching a single expected-output file across this repo's PG10-18 matrix.

3. Wire it up

• PGXNTOOL_ENABLE_TEST_BUILD = yes explicit in the Makefile (avoids silently disabling the check if test/build/'s contents were ever accidentally deleted).
• pgxn-tools' pg-build-test never calls make test, so test-build (wired only into test's dependency chain) would never run in CI. Replaced with a direct make verify-results step, which also correctly detects failures that pg-build-test's make installcheck call cannot (pgxntool marks installcheck .IGNORE, so its exit code doesn't reflect real regression failures).

Test plan

• make test passes on PG17 and PG12 (including the new test-build step)
• Simulated CI's exact sequence from a fully clean state -- no pre-installed extension, no leftover roles/databases
• Deliberately introduced a syntax error and confirmed test/build/syntax.sql surfaced it clearly and immediately; reverted before committing
• test/build/expected/syntax.out generated from a real run (never hand-authored)

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b8f025af-fe40-4ed6-b4ff-1ea7cd89e71d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}