fix(signage-manager): match schedule conflicts to the player - #537
Merged
Merged
Conversation
|
Deployment failed for project frontend-templates with the following error: Learn More: https://vercel.com/placeos?upgradeToPro=build-rate-limit |
This was referenced Oct 2, 2026
|
Collaborator
Author
|
LGTM |
- Ignore disabled playlists in conflict detection. - Respect playlist and schedule validity to the minute. - Drop conflicts that already ended, and include runs still playing from the previous day. - A single pass does not conflict with a timed takeover. - Do not draw times skipped by a DST change. - Playlists without schedules play all day, never as a takeover. - Search displays by every zone name, label disabled blocks, and use the locale for hour labels.
On a spring-forward day, playedRun added the play length to clock minutes, so a run ended an hour early on the timeline and conflicts in the extra hour were missed. The end now comes from the elapsed length, as on the player, then is cut at valid_until. On the fall-back day a run is never shorter on the clock than its length.
MrYuion
force-pushed
the
fix/signage-manager-schedules
branch
from
October 2, 2026 05:45
7cff910 to
e992ca1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schedule conflicts and the timeline did not match what the player does:
Changes
playlistScheduleswith no schedules gives one all-day, non-takeover schedule. It is exported once and replaces the copy inplaylist-item-details.all_dayfrom one helper.[(ngModel)],linkedSignalfor the tab, and hour labels in the locale.Testing
nx test signage-manager(979) andnx build signage-managerpass.Merge order
Conflicts with #531 only in
apps/signage-manager/USER_STORIES.md. Based ondevelop.Changes made by Claude Opus 5.5 (1M context) in Claude Code, running in T3 Code.
🤖 Generated with Claude Code