fix(signage-manager): fix shared list, decode and picker behaviour - #531
Merged
Merged
Conversation
- Load displays for the inventory and command palette with querySignageDisplays, so never-seen displays are not shown online. - decodeEntityNames keeps the class prototype, so getters such as SignageMedia.media_url work. - PagedList.reset(null) clears loading. - PagedSearch exposes error and retry; the display and zone pickers show a load error with Retry. - The command palette hides the previous term's matches while the new term is debounced. - The shared Retry button no longer submits a surrounding form.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This was referenced Oct 2, 2026
|
…arch - decodeEntityNames returns its own copies unchanged, so an item that passes through querySignageDisplays and then a list helper is decoded once. A saved "&" no longer turns into "&". - PagedSearch.retry() does nothing while a new term waits for its debounce, so it cannot show the old term's matches.
|
Deployment failed for project frontend-templates with the following error: Learn More: https://vercel.com/placeos?upgradeToPro=build-rate-limit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared signage-manager code had several bugs that affected many pages:
querySystems, which fills a missingsignage_last_seenwith "now". A display that never checked in showed Online on Schedules.decodeEntityNames: it copied items with{ ...item }, which drops class getters.SignageMedia.media_urlwasundefined, so the edit modal preview was blank.PagedList:reset(null)while a page was loading leftloadingstuck.PagedSearch: it had no error state, so failed picker searches showed "No displays" or "No zones".<load-error>: the Retry button had notype="button", so inside a form it submitted the form and reloaded the page.Changes
querySignageDisplaysin the inventory and the command palette.decodeEntityNames: keeps the prototype and is typedT.PagedList:resetclearsloading.PagedSearch:errorandretry(). The display and zone pickers show<load-error>.<load-error>(libs/components): the Retry button getstype="button".Testing
nx test signage-manager,nx test componentsandnx build signage-managerpass.&names decoded in every list, and no console errors.Merge order
Conflicts with #532 and #537 only in
apps/signage-manager/USER_STORIES.md. Whichever merges later needs a rebase. Based ondevelop.Changes made by Claude Opus 5.5 (1M context) in Claude Code, running in T3 Code.
🤖 Generated with Claude Code