chore: remove dead code and fix locale keys and form labels

CLAUDE.md

@@ -4,7 +4,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 ## Project Overview
 
-PlaceOS Backoffice is an Angular 20 admin UI for managing PlaceOS building automation systems. It uses standalone components (no NgModules), zoneless change detection with signals, and integrates with PlaceOS backend APIs.
+PlaceOS Backoffice is an Angular 22 admin UI for managing PlaceOS building automation systems. It uses standalone components (no NgModules), zoneless change detection with signals, and integrates with PlaceOS backend APIs.
 
 ## Commands
 
@@ -25,10 +25,10 @@ bun run lint                           # ESLint
 
 ## Tech Stack
 
-- **Framework**: Angular 20 with standalone components and signals
+- **Framework**: Angular 22 with standalone components and signals
 - **Build**: Nx 23 + Vite 8 + @analogjs/vite-plugin-angular
 - **Testing**: Vitest + Playwright
-- **Styling**: Tailwind CSS 3.4 with custom CSS variables
+- **Styling**: Tailwind CSS 4 (legacy `tailwind.config.js` loaded via `@config`) with custom CSS variables
 - **Backend**: @placeos/ts-client for PlaceOS REST API integration
 - **Real-time**: MQTT for dashboard updates
 
@@ -54,7 +54,7 @@ src/app/
 Each feature follows this structure:
 - `*.routes.ts` - Lazy-loaded feature routing
 - `*-state.service.ts` - Feature state management with signals/observables
-- Component files with `standalone: true`
+- Standalone components (the default since Angular 19, so `standalone: true` is not needed)
 
 ### Key Patterns
 
@@ -90,11 +90,11 @@ export class MyComponent extends AsyncHandler {
 
 ## Notes
 
-- Angular 20 with standalone components and signals
-- TypeScript 5.8.3
+- Angular 22 with standalone components and signals
+- TypeScript ~6.0
 - Supports multiple locales (see `app.locales` in settings)
 - Service worker support for PWA functionality (production builds)
-- Custom localization support via `public/assets/locales`, **TranslationPipe** and **LocalesService**
+- Custom localization support via `public/assets/locale`, **TranslatePipe** and **LocaleService**. `en-AU.json` is the fallback locale
 - Use **IconComponent** for icons
 
 ## Code styles

e2e/src/admin.spec.ts

@@ -286,24 +286,6 @@ test.describe('Admin', () => {
         });
     });
 
-    /**
-     * US-ADM-014: Manage Email Templates
-     * NOTE: This test is skipped because the mailing-list tab is disabled in the application
-     */
-    test.describe('US-ADM-014: Manage Email Templates', () => {
-        test.skip('AC-ADM-014-1: View Templates - should show email templates section', async ({
-            page,
-        }) => {
-            await adminPage.goto();
-
-            // Navigate to email templates section
-            await adminPage.viewEmailTemplates();
-
-            // Verify content is displayed
-            await expect(adminPage.mainContent).toBeVisible();
-        });
-    });
-
     /**
      * US-ADM-015: Monitor Build Jobs
      */

e2e/src/pages/admin.page.ts

@@ -101,14 +101,6 @@ export class AdminPage extends BasePage {
         return this.page.locator('a[href*="/admin/upload-library"]').first();
     }
 
-    /**
-     * Get the mailing list section link (route: /admin/mailing-list)
-     * NOTE: This tab is currently disabled in the application
-     */
-    get mailingListLink(): Locator {
-        return this.page.locator('a[href*="/admin/mailing-list"]').first();
-    }
-
     /**
      * Get the build jobs section link (route: /admin/build-jobs)
      */
@@ -448,35 +440,6 @@ export class AdminPage extends BasePage {
         await this.save();
     }
 
-    // Email Templates
-
-    /**
-     * View email templates
-     */
-    async viewEmailTemplates(): Promise<void> {
-        await this.mailingListLink.click();
-        await this.page.waitForTimeout(500);
-    }
-
-    /**
-     * Create email template
-     */
-    async createEmailTemplate(data: {
-        name: string;
-        subject: string;
-        body: string;
-    }): Promise<void> {
-        await this.viewEmailTemplates();
-        await this.addButton.click();
-        await this.dialog.waitFor({ timeout: 5000 });
-
-        await this.fillField('Name', data.name);
-        await this.fillField('Subject', data.subject);
-        await this.fillField('Body', data.body);
-
-        await this.save();
-    }
-
     // Build Jobs
 
     /**

public/assets/locale/ar.json

@@ -119,7 +119,7 @@
         "SETTINGS_MASKED_ERROR": "استبدل جميع القيم المخفية قبل حفظ الإعدادات المشفرة",
         "SETTINGS_INHERITED": "إعداد موروث من [{{ parent }}]({{ path }})({{ type }})",
         "SETTINGS_LOCAL": "إعداد محلي من {{ type }}",
-        "SETTINGS_SAVE_ERROR": "فشل حفظ الإعدادات. الخطأ {{ error }}",
+        "SETTINGS_SAVE_ERROR": "فشل حفظ الإعدادات. الخطأ: {{ error }}",
         "SETTINGS_SAVE_SUCCESS": "تم حفظ تغييرات إعدادات {{ type }} بنجاح",
         "SETTINGS_SAVE_SUCCESS_ALL": "تم حفظ جميع تغييرات الإعدادات بنجاح",
         "ADD_EXISTING": "إضافة موجود",
@@ -532,7 +532,7 @@
         "FIELD_ACTION_FN_CALL": "إجراء استدعاء وظيفة",
         "FIELD_ACTION_EMAIL": "إجراء بريد إلكتروني",
         "REORDER_CONFIRM_TITLE": "إعادة ترتيب إجراء {{ type }} للمحفز",
-        "REORDER_CONFIRM_MSG": "هل أنت متأكد أنك تريد إزالة شرط المحفز هذا؟<br>سيتم تحديث جميع الأنظمة التي تستخدم هذا المحفز <strong>فوراً</strong>.",
+        "REORDER_CONFIRM_MSG": "هل أنت متأكد أنك تريد إعادة ترتيب إجراءات المحفز؟<br>سيتم تحديث جميع الأنظمة التي تستخدم هذا المحفز <strong>فوراً</strong>.",
         "REORDER_CONFIRM_LOADING": "جاري إعادة ترتيب إجراءات المحفز...",
         "REORDER_CONFIRM_ERROR": "فشل في إعادة ترتيب إجراء المحفز. الخطأ: {{ error }}",
         "REORDER_CONFIRM_SUCCESS": "تم إعادة ترتيب إجراء المحفز بنجاح",
@@ -626,7 +626,7 @@
         "STAFF_CARD": "رقم البطاقة",
         "PASSWORD_REQUIRED": "مطلوب كلمة مرور صالحة",
         "PASSWORD_CONFIRM": "تأكيد كلمة المرور",
-        "PASSOWRD_MATCH": "كلمات المرور غير متطابقة"
+        "PASSWORDS_MATCH": "كلمات المرور غير متطابقة"
     },
     "DOMAINS": {
         "SINGULAR": "مجال",
@@ -686,8 +686,8 @@
         "AUTHENTICATION_EMPTY": "لا توجد طرق مصادقة لهذا المجال",
         "AUTHENTICATION_SOURCE_TYPE": "نوع مصدر المصادقة",
         "AUTHENTICATION_SOURCE_SELECT": "اختر مصدر المصادقة...",
-        "AUTHENTICATION_SAVE_ERROR": "تم تحديث مصدر المصادقة بنجاح",
-        "AUTHENTICATION_SAVE_SUCCESS": "فشل تحديث مصدر المصادقة. الخطأ: {{ error }}",
+        "AUTHENTICATION_SAVE_SUCCESS": "تم تحديث مصدر المصادقة بنجاح",
+        "AUTHENTICATION_SAVE_ERROR": "فشل تحديث مصدر المصادقة. الخطأ: {{ error }}",
         "AUTHENTICATION_NAME_REQUIRED": "مطلوب اسم لمصدر المصادقة",
         "OAUTH_SITE": "الموقع",
         "OAUTH_SITE_PLACEHOLDER": "عنوان URL لموفر SSO",
@@ -896,7 +896,7 @@
         "APP_KEYS_LAST_DETAILS": "آخر تفاصيل مفتاح تطبيق",
         "APP_KEYS_FIELD_SCOPES": "نطاقات",
         "APP_KEYS_FIELD_PERMISSIONS": "الوصول",
-        "APP_KEYS_SCOPES_REQUIRE": "مطلوب نطاق واحد على الأقل",
+        "APP_KEYS_SCOPES_REQUIRED": "مطلوب نطاق واحد على الأقل",
         "APP_KEYS_NAME_REQUIRED": "مطلوب اسم",
         "APP_KEYS_PERMISSIONS_EMPTY": "لا توجد أذونات",
         "APP_KEYS_COPIED": "تم نسخ مفتاح التطبيق إلى الحافظة",

public/assets/locale/en-AU.json

@@ -49,6 +49,9 @@
         "CANCEL": "Cancel",
         "CLOSE": "Close",
         "CONFIRM": "Confirm",
+        "ITEM_REMOVE": "Remove {{ item }}",
+        "FIELD_REQUIRED": "This field is required",
+        "DATE_EMPTY": "No date selected",
         "SAVE": "Save",
         "SAVE_ALL": "Save All",
         "CLEAR": "Clear Changes",
@@ -70,6 +73,7 @@
         "ITEM_ADD_SELECTED": "Add selected",
         "PROCESSING_REQUEST": "Processing request...",
         "PASSWORD": "Password",
+        "PASSWORD_TOGGLE": "Show password",
         "IMAGE_ADD_URL": "Add image via URL",
         "IMAGE_UPLOADS": "Upload Image(s)",
         "DROP_UPLOAD_MSG": "Drop files to upload them to the cloud",
@@ -139,7 +143,7 @@
         "SETTINGS_MASKED_ERROR": "Replace all masked values before you save encrypted settings",
         "SETTINGS_INHERITED": "Setting inherited from [{{ parent }}]({{ path }})({{ type }})",
         "SETTINGS_LOCAL": "Local setting from {{ type }}",
-        "SETTINGS_SAVE_ERROR": "Failed to save settings. Error {{ error }}",
+        "SETTINGS_SAVE_ERROR": "Failed to save settings. Error: {{ error }}",
         "SETTINGS_SAVE_SUCCESS": "Successfully saved {{ type }} settings changes",
         "SETTINGS_SAVE_SUCCESS_ALL": "Successfully saved all settings changes",
         "ADD_EXISTING": "Add existing",
@@ -607,8 +611,8 @@
         "ACTION_FN_EMPTY": "No function call actions for this trigger",
         "FIELD_ACTION_FN_CALL": "Function call Action",
         "FIELD_ACTION_EMAIL": "Email Action",
-        "REORDER_CONFIRM_TITLE": "Reoreder trigger {{ type }} action",
-        "REORDER_CONFIRM_MSG": "Are you sure you want remove this trigger condition?<br>All systems using this trigger will be updated <strong>immediately</strong>.",
+        "REORDER_CONFIRM_TITLE": "Reorder trigger {{ type }} action",
+        "REORDER_CONFIRM_MSG": "Are you sure you want to reorder the trigger actions?<br>All systems using this trigger will be updated <strong>immediately</strong>.",
         "REORDER_CONFIRM_LOADING": "Re-ordering trigger actions...",
         "REORDER_CONFIRM_ERROR": "Failed to re-ordered trigger action. Error: {{ error }}",
         "REORDER_CONFIRM_SUCCESS": "Successfully re-ordered trigger action",
@@ -679,6 +683,7 @@
         "NEW": "New user",
         "BULK": "Bulk add users",
         "REMOVE": "Remove user",
+        "DELETE": "Delete user",
         "DELETE_MSG": "<p>Are you sure you want delete this user?</p><p>The user will be removed from the system within 24 hours</p>",
         "DELETE_LOADING": "Deleting user...",
         "DELETE_SUCCESS": "Successfully deleted user.",
@@ -729,7 +734,7 @@
         "STAFF_CARD": "Card Number",
         "PASSWORD_REQUIRED": "A valid password is required",
         "PASSWORD_CONFIRM": "Confirm Password",
-        "PASSOWRD_MATCH": "Passwords do not match",
+        "PASSWORDS_MATCH": "Passwords do not match",
         "IMAGE": "Profile Image",
         "IMAGE_INVALID": "A valid URL is required for profile image",
         "LOCATABLE": "Enable Location Tracking"
@@ -867,9 +872,9 @@
         "FIELD_USER": "User",
         "FIELD_ROLE": "Role",
         "APPLICATIONS_EMPTY": "No applications for this domain",
-        "APPLICATIONS_SAVING": "Saving domain application...",
-        "APPLICATIONS_SAVE_ERROR": "Failed to save domain application",
-        "APPLICATIONS_SAVE_SUCCESS": "Successfully saved domain application",
+        "APPLICATION_SAVING": "Saving domain application...",
+        "APPLICATION_SAVE_ERROR": "Failed to save domain application. Error: {{ error }}",
+        "APPLICATION_SAVE_SUCCESS": "Successfully saved domain application",
         "COPY_SECRET": "Copy secret to Clipboard",
         "COPIED_SECRET": "Copied client secret to Clipboard",
         "VIEW_SECRET": "View Secret",
@@ -891,8 +896,8 @@
         "AUTHENTICATION_EMPTY": "No authentication methods for this domain",
         "AUTHENTICATION_SOURCE_TYPE": "Authentication Source Type",
         "AUTHENTICATION_SOURCE_SELECT": "Select authentication source...",
-        "AUTHENTICATION_SAVE_ERROR": "Successfully updated authentication source",
-        "AUTHENTICATION_SAVE_SUCCESS": "Failed to update authentication source. Error: {{ error }}",
+        "AUTHENTICATION_SAVE_SUCCESS": "Successfully updated authentication source",
+        "AUTHENTICATION_SAVE_ERROR": "Failed to update authentication source. Error: {{ error }}",
         "AUTHENTICATION_NAME_REQUIRED": "An auth source name is required",
         "OAUTH_SITE": "Site",
         "OAUTH_SITE_PLACEHOLDER": "URL of the SSO provider",
@@ -1020,14 +1025,17 @@
         "BROKERS_AUTH_TYPE_NONE": "No Auth",
         "BROKERS_FILTERS_EMPTY": "No filters",
         "BROKERS_NAME_REQUIRED": "A broker name is required",
-        "BROKERS_HOST_REQUIRED": "A broker name is required",
+        "BROKERS_HOST_REQUIRED": "A broker host is required",
         "BROKERS_PORT_REQUIRED": "A valid port number between 1 - 65535 is required",
         "BROKERS_USERNAME": "Username",
         "BROKERS_USERNAME_REQUIRED": "A valid username is required",
         "BROKERS_PASSWORD": "Password",
         "BROKERS_PASSWORD_REQUIRED": "A valid password is required ",
         "BROKERS_CERT": "Certificate",
         "BROKERS_CERT_REQUIRED": "A valid certificate is required ",
+        "BROKERS_SAVING": "Saving MQTT broker...",
+        "BROKERS_SAVE_ERROR": "Failed to save MQTT broker. Error: {{ error }}",
+        "BROKERS_SAVE_SUCCESS": "Successfully saved MQTT broker.",
         "TENANTS_HEADER": "Staff API Tenants",
         "TENANTS_ADD": "Add Tenant",
         "TENANTS_NEW": "New Tenant",
@@ -1122,7 +1130,7 @@
         "APP_KEYS_TTL_MONTH": "30 Days",
         "APP_KEYS_TTL_90_DAYS": "90 Days",
         "APP_KEYS_TTL_YEAR": "1 Year",
-        "APP_KEYS_SCOPES_REQUIRE": "At least one scope is required",
+        "APP_KEYS_SCOPES_REQUIRED": "At least one scope is required",
         "APP_KEYS_NAME_REQUIRED": "A name is required",
         "APP_KEYS_PERMISSIONS_EMPTY": "No permissions",
         "APP_KEYS_COPIED": "Copied Application Key to clipboard",

public/assets/locale/en-GB.json

@@ -124,7 +124,7 @@
         "SETTINGS_MASKED_ERROR": "Replace all masked values before you save encrypted settings",
         "SETTINGS_INHERITED": "Setting inherited from [{{ parent }}]({{ path }})({{ type }})",
         "SETTINGS_LOCAL": "Local setting from {{ type }}",
-        "SETTINGS_SAVE_ERROR": "Failed to save settings. Error {{ error }}",
+        "SETTINGS_SAVE_ERROR": "Failed to save settings. Error: {{ error }}",
         "SETTINGS_SAVE_SUCCESS": "Successfully saved {{ type }} settings changes",
         "SETTINGS_SAVE_SUCCESS_ALL": "Successfully saved all settings changes",
         "ADD_EXISTING": "Add existing",
@@ -531,7 +531,7 @@
         "ACTIONS": "Actions",
         "ACTION_ADD": "Add Action",
         "ACTION_NEW": "New Action",
-        "ACTION_FIELD_TYPE": "ACtion Type",
+        "ACTION_FIELD_TYPE": "Action Type",
         "ACTION_EXECUTE": "Execute Method",
         "ACTION_EXECUTE_SELECT": "Select method to execute",
         "ACTION_EMAIL": "Send Email",
@@ -542,8 +542,8 @@
         "ACTION_FN_EMPTY": "No function call actions for this trigger",
         "FIELD_ACTION_FN_CALL": "Function call Action",
         "FIELD_ACTION_EMAIL": "Email Action",
-        "REORDER_CONFIRM_TITLE": "Reoreder trigger {{ type }} action",
-        "REORDER_CONFIRM_MSG": "Are you sure you want remove this trigger condition?<br>All systems using this trigger will be updated <strong>immediately</strong>.",
+        "REORDER_CONFIRM_TITLE": "Reorder trigger {{ type }} action",
+        "REORDER_CONFIRM_MSG": "Are you sure you want to reorder the trigger actions?<br>All systems using this trigger will be updated <strong>immediately</strong>.",
         "REORDER_CONFIRM_LOADING": "Re-ordering trigger actions...",
         "REORDER_CONFIRM_ERROR": "Failed to re-ordered trigger action. Error: {{ error }}",
         "REORDER_CONFIRM_SUCCESS": "Successfully re-ordered trigger action",
@@ -639,7 +639,7 @@
         "STAFF_CARD": "Card Number",
         "PASSWORD_REQUIRED": "A valid password is required",
         "PASSWORD_CONFIRM": "Confirm Password",
-        "PASSOWRD_MATCH": "Passwords do not match"
+        "PASSWORDS_MATCH": "Passwords do not match"
     },
     "DOMAINS": {
         "SINGULAR": "Domain",
@@ -699,8 +699,8 @@
         "AUTHENTICATION_EMPTY": "No authentication methods for this domain",
         "AUTHENTICATION_SOURCE_TYPE": "Authentication Source Type",
         "AUTHENTICATION_SOURCE_SELECT": "Select authentication source...",
-        "AUTHENTICATION_SAVE_ERROR": "Successfully updated authentication source",
-        "AUTHENTICATION_SAVE_SUCCESS": "Failed to update authentication source. Error: {{ error }}",
+        "AUTHENTICATION_SAVE_SUCCESS": "Successfully updated authentication source",
+        "AUTHENTICATION_SAVE_ERROR": "Failed to update authentication source. Error: {{ error }}",
         "AUTHENTICATION_NAME_REQUIRED": "An auth source name is required",
         "OAUTH_SITE": "Site",
         "OAUTH_SITE_PLACEHOLDER": "URL of the SSO provider",
@@ -827,7 +827,7 @@
         "BROKERS_AUTH_TYPE_NONE": "No Auth",
         "BROKERS_FILTERS_EMPTY": "No filters",
         "BROKERS_NAME_REQUIRED": "A broker name is required",
-        "BROKERS_HOST_REQUIRED": "A broker name is required",
+        "BROKERS_HOST_REQUIRED": "A broker host is required",
         "BROKERS_PORT_REQUIRED": "A valid port number between 1 - 65535 is required",
         "BROKERS_USERNAME": "Username",
         "BROKERS_USERNAME_REQUIRED": "A valid username is required",
@@ -927,7 +927,7 @@
         "APP_KEYS_TTL_MONTH": "30 Days",
         "APP_KEYS_TTL_90_DAYS": "90 Days",
         "APP_KEYS_TTL_YEAR": "1 Year",
-        "APP_KEYS_SCOPES_REQUIRE": "At least one scope is required",
+        "APP_KEYS_SCOPES_REQUIRED": "At least one scope is required",
         "APP_KEYS_NAME_REQUIRED": "A name is required",
         "APP_KEYS_PERMISSIONS_EMPTY": "No permissions",
         "APP_KEYS_COPIED": "Copied Application Key to clipboard",