chore: remove dead code and fix locale keys and form labels - #317
Merged
Merged
Conversation
Rename typo'd locale keys (PASSOWRD_MATCH, APP_KEYS_SCOPES_REQUIRE, APPLICATIONS_SAVE_*), swap the inverted AUTHENTICATION_SAVE_* messages, add missing en-AU keys, and fix mistyped keys in code. Translate the zone trigger remove tooltip and the confirm modal default title. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- function-argument: guard against a missing method or order list - binding directive: test the model value, not the signal object - counter: keep the last valid value on non-numeric input - saml-source-form: give each mapping update its own timeout - user-menu-tooltip: use rel="noopener noreferrer" - simple-table: render the table as a div, not a button - timezone-helpers: parse longOffset so zones like Sydney and Kolkata give correct offsets - item.service: read route segments with parseUrl, so query params do not leak into the resource type or item id - driver-form: drop a date comparison that was always true - item-sidebar: load groups on NavigationEnd only, and stop the parent walk on cyclic data - settings-field: stop recreating Monaco on window resize, and show an empty editor for null values - new-terminal: escape log HTML before adding colour spans Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Add ids so label for values match their inputs in the user, broker, domain, application, zone and metadata forms. Use aria-labelledby for mat-select fields. Replace copy-pasted chip grid aria-labels. Make the user form show-password toggles real buttons with an aria-label. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- GoogleAnalyticsService (init() was never called, so send() did nothing) - SettingsService overrides setter and _applyCssVariables - hasNewVersion, clearCacheCheck, validateURL, validateMatch - unused ApplicationLink*, CreateEditModalData and DriverInitData types - unused AppComponent members and commented-out blocks - duplicated, never-called newSettings() in five forms - hardcoded email check that hid user password fields - admin mailing lists feature, its routes and skipped e2e test - unused overlay, context menu, sidebar, admin and guard members Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
DEFAULT_SETTINGS.debug was true, so production builds logged debug output and skipped locale caching. Debug now turns on in dev mode, or when localStorage BACKOFFICE.debug is set to true. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Angular 22, TypeScript ~6.0 and Tailwind 4. Also fix the locale folder and the translate pipe and locale service names. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Keep a for attribute on the labels of mat-select fields, and drop the table-wide click handler in simple-table. Its onclick output always emitted 0 and had no listeners. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Give matInput fields the id their label points at. Use aria-labelledby for mat-select fields. Give custom field components (a-counter, item-search-field, image-list-field) role=group and aria-labelledby, since a label for cannot target them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The toggle click bubbled to the mat-form-field container, which focused the password input. A second Space then typed into the password. Stop the click at the toggle in the user and repository forms, and give the repository toggle an accessible name. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
USERS.PASSWORDS_MATCHandDOMAINS.APPLICATION_SAVE_ERROR. Some keys had typos in the code or in the locale files. The authentication save success and error messages were swapped in all 7 locales.newSettingsin 5 forms, and a hard-coded user email check in the user form.DEFAULT_SETTINGS.debugwastruein production.CLAUDE.mdlisted old versions.This is part of a stack of 6 PRs from a review of the whole app. Merge them in order: confirm-cancel, security, data loss, broken features, async errors, cleanup. Each PR targets the branch before it, so the diff shows only its own changes.
Fix
role="group"witharia-labelledby. Password toggles are buttons witharia-pressed, and they keep focus.debugis off by default. It turns on in dev builds, or when localStorageBACKOFFICE.debugis'true'.LLLL YYYYweek years, a null check infunction-argument, and awhileloop with no limit in the sidebar.CLAUDE.mdto Angular 22 and TypeScript 6.0.Turning on
strictNullChecksgives 345 errors today, before template errors. I left it off.Checks
tsc,bun run lint,bunx vitest run(1011 tests) andbun run buildpass. The test count drops because tests for deleted code went with it.label[for]in each form points at an element.Made by Claude Opus 5.5 (1M context) in Claude Code (T3 Code).
🤖 Generated with Claude Code