Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/src/main/res/values/strings_settings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
<string name="setcat_language_turkish" translatable="false">Türkçe</string>
<string name="language_zh_rCN" translatable="false">简体中文</string>
<string name="setcat_language_vietnamese" translatable="false">Tiếng Việt</string>
<string name="setcat_language_portuguese_br" translatable="false">Português (Brasil)</string>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Brazilian Portuguese stays unavailable

Adding this string does not complete pt-BR registration. AppLanguage has no PORTUGUESE_BR entry, and both language pickers get their choices from its entries. Users still cannot select Brazilian Portuguese. Add the pt-BR entry referencing this label and update the test that currently expects pt-BR to be unsupported.

Knowledge Base Used: Backup, restore, and settings

Prompt To Fix With AI
This is a comment left during a code review.
Path: app/src/main/res/values/strings_settings.xml
Line: 109

Comment:
**Brazilian Portuguese stays unavailable**

Adding this string does not complete pt-BR registration. `AppLanguage` has no `PORTUGUESE_BR` entry, and both language pickers get their choices from its entries. Users still cannot select Brazilian Portuguese. Add the `pt-BR` entry referencing this label and update the test that currently expects `pt-BR` to be unsupported.

**Knowledge Base Used:** [Backup, restore, and settings](https://app.greptile.com/-/switch-tenant?tenant=moli&next=%2Fcustom-context%2Fknowledge-base%2Fpixelplayerhq%2Fpixelplayeross%2F-%2Fdocs%2Fbackup-restore-and-settings.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

<string name="setcat_app_theme_label">App Theme</string>
<string name="setcat_app_theme_desc">Switch between light, dark, or follow system appearance.</string>
<string name="setcat_global_now_playing_theme_title">Use now playing colors across the app</string>
Expand Down