Repository navigation
Brazilian Portuguese language label - #233
AdaLovelace2077 wants to merge 1 commit into
Conversation
[Low impact] The change is limited to one language-name resource. Complete the missing
|
| <string name="setcat_language_turkish" translatable="false">Türkçe</string> | ||
| <string name="language_zh_rCN" translatable="false">简体中文</string> | ||
| <string name="setcat_language_vietnamese" translatable="false">Tiếng Việt</string> | ||
| <string name="setcat_language_portuguese_br" translatable="false">Português (Brasil)</string> |
There was a problem hiding this comment.
Brazilian Portuguese stays unavailable
Adding this string does not complete pt-BR registration. AppLanguage has no PORTUGUESE_BR entry, and both language pickers get their choices from its entries. Users still cannot select Brazilian Portuguese. Add the pt-BR entry referencing this label and update the test that currently expects pt-BR to be unsupported.
Knowledge Base Used: Backup, restore, and settings
Prompt To Fix With AI
This is a comment left during a code review.
Path: app/src/main/res/values/strings_settings.xml
Line: 109
Comment:
**Brazilian Portuguese stays unavailable**
Adding this string does not complete pt-BR registration. `AppLanguage` has no `PORTUGUESE_BR` entry, and both language pickers get their choices from its entries. Users still cannot select Brazilian Portuguese. Add the `pt-BR` entry referencing this label and update the test that currently expects `pt-BR` to be unsupported.
**Knowledge Base Used:** [Backup, restore, and settings](https://app.greptile.com/-/switch-tenant?tenant=moli&next=%2Fcustom-context%2Fknowledge-base%2Fpixelplayerhq%2Fpixelplayeross%2F-%2Fdocs%2Fbackup-restore-and-settings.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Adds the setcat_language_portuguese_br string used by the new PORTUGUESE_BR entry in AppLanguage, completing pt-BR registration (follow-up to the previous locale PRs).