Skip to content

Brazilian Portuguese language label - #233

Closed
AdaLovelace2077 wants to merge 1 commit into
PixelPlayerHQ:mainfrom
AdaLovelace2077:patch-1
Closed

AdaLovelace2077 wants to merge 1 commit into
PixelPlayerHQ:mainfrom
AdaLovelace2077:patch-1

Conversation

@AdaLovelace2077

Copy link
Copy Markdown

Adds the setcat_language_portuguese_br string used by the new PORTUGUESE_BR entry in AppLanguage, completing pt-BR registration (follow-up to the previous locale PRs).

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The change is limited to one language-name resource.

Complete the missing AppLanguage entry before merging this as the pt-BR registration fix.

Fix All in Claude CodeFindings

  1. P1 Brazilian Portuguese stays unavailable ▶
Fix with agent prompt
### Issue 1
app/src/main/res/values/strings_settings.xml:109
Adding this string does not complete pt-BR registration. `AppLanguage` has no `PORTUGUESE_BR` entry, and both language pickers get their choices from its entries. Users still cannot select Brazilian Portuguese. Add the `pt-BR` entry referencing this label and update the test that currently expects `pt-BR` to be unsupported.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds the non-translatable “Português (Brasil)” label.

  • The settings resources now include a Brazilian Portuguese language name.

Reviews (1) · Last reviewed commit: "Add Portuguese (Brazil) language string" · Reviewed by Greptile

<string name="setcat_language_turkish" translatable="false">Türkçe</string>
<string name="language_zh_rCN" translatable="false">简体中文</string>
<string name="setcat_language_vietnamese" translatable="false">Tiếng Việt</string>
<string name="setcat_language_portuguese_br" translatable="false">Português (Brasil)</string>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Brazilian Portuguese stays unavailable

Adding this string does not complete pt-BR registration. AppLanguage has no PORTUGUESE_BR entry, and both language pickers get their choices from its entries. Users still cannot select Brazilian Portuguese. Add the pt-BR entry referencing this label and update the test that currently expects pt-BR to be unsupported.

Knowledge Base Used: Backup, restore, and settings

Prompt To Fix With AI
This is a comment left during a code review.
Path: app/src/main/res/values/strings_settings.xml
Line: 109

Comment:
**Brazilian Portuguese stays unavailable**

Adding this string does not complete pt-BR registration. `AppLanguage` has no `PORTUGUESE_BR` entry, and both language pickers get their choices from its entries. Users still cannot select Brazilian Portuguese. Add the `pt-BR` entry referencing this label and update the test that currently expects `pt-BR` to be unsupported.

**Knowledge Base Used:** [Backup, restore, and settings](https://app.greptile.com/-/switch-tenant?tenant=moli&next=%2Fcustom-context%2Fknowledge-base%2Fpixelplayerhq%2Fpixelplayeross%2F-%2Fdocs%2Fbackup-restore-and-settings.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

@AdaLovelace2077
AdaLovelace2077 deleted the patch-1 branch November 12, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant