Skip to content

fix(qt): preserve Game Mode focus and screenshot cancellation - #1124

Merged
zortos293 merged 1 commit into
devfrom
zortos293/game-mode-audit-regressions
Oct 6, 2026
Merged

zortos293 merged 1 commit into
devfrom
zortos293/game-mode-audit-regressions

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

Fixes four behavioral regressions found in the post-merge audit of #1120. This preserves the approved Game Mode layout and stays separate from #1123's Paper-spacing work.

Navigation and shared controls

  • Restore Store selection against the loaded catalog instead of capping it to the first 30 tiles, and reveal the selected tile after Back or delayed loading.
  • Keep focused store-chip identity through metadata reorder and delegate removal. Enter resolves that identity even before deferred focus restoration, without selecting a different store or taking focus from a sheet or new action.
  • Add opt-in compact typography for the existing 56px desktop Friends rows. Default console setting rows retain their redesigned layout.

Deferred screenshots

Cancel a pending guide screenshot immediately when another overlay opens, media readiness is lost, or the session changes. An uninterrupted request still waits for guide dismissal and two rendered frames, retains the same native item, and captures exactly once.

Verification

  • New regression checks failed before the fixes for Store selection, reordered chip focus, compact-row overflow, and transient-overlay screenshot cancellation.
  • 424/424 Qt CTest targets passed on the final build, including normal/reduced-motion and windowed/fullscreen session checks. 217 Python contracts, localization validation, and git diff --check passed.
  • Matched active Qt parent/merge/fixed renders use identical data, dimensions, and Nocturne settings. Broader fixtures cover all eight settings sections, supporting pages, long German text, empty/loading/error/populated data, overlays, and desktop shared controls at 960×540, 1280×800, and 1920×1080, with simulated 1.25/1.5 scaling.
  • Actual focused guide Enter saves exactly one scratch screenshot after two clean frames; transient overlay and session-replacement races produce zero attempts. Real X11 pointer/keyboard checks confirm the UI-sounds toggle, held-key skip drain, destination preservation, and safe Enter activation.
  • Independent GPT-6.1 Sol review found no blocking production issue; its two coverage gaps were exercised afterward.

These are credential-free Linux Qt fixtures, not live gameplay, hardware decode/HDR, physical-controller, audio audibility/system-mute, Windows, Wayland, or Flatpak acceptance.

Store selection before and after

Focused store identity before and after

Desktop Friends row overflow before and after

Screenshot cancellation before and after

Open in Capy

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9a0bdc73-680a-4743-8553-436ac4b00c39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zortos293
zortos293 merged commit a5f3c04 into dev Oct 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant