Skip to content

fix(qt): keep desktop session reports in control of focus - #1126

Merged
zortos293 merged 1 commit into
devfrom
capy/keep-desktop-session-reports
Oct 6, 2026
Merged

zortos293 merged 1 commit into
devfrom
capy/keep-desktop-session-reports

Conversation

@zortos293

Copy link
Copy Markdown
Collaborator

The newly enabled desktop session-report path from #1123 opens after navigation to game details. The details modal's deferred focus callback could then take focus from the report, leaving Return and Space routed to the background game action.

  • Give desktop session reports the existing shared modal owner, which disables background route input and reclaims focus from deferred callbacks. Keep system-warning precedence and other desktop overlays unchanged.
  • Add stable report/control targets and two normal/reduced-motion regression cases in the existing detail acceptance workload. Verify default Done focus, no background Play signal, safe dismissal, focus hand-back, and Diagnostics activation without weakening existing detail checks.

Both new tests failed before the fix and pass afterward. 466/466 Qt CTest targets, 217 Python contracts, localization validation, and git diff --check pass. Fresh active-window fixtures exercise actual mocked stop responses through report construction, Done/Diagnostics, disabled reports and unavailable/error telemetry, plus Return/Space isolation. Preserved Store/chip/Friends regressions and all 16 deferred screenshot window/motion cases pass.

The grouped post-merge audit used the actual #1124 and #1123 landed trees separately, then this fix. These are credential-free Linux Qt fixtures, not live gameplay, physical-controller, hardware decode/HDR, Windows UI, Wayland, physical DPR/monitor migration, audible/system-mute, or Flatpak acceptance. Report data, layouts and native media are unchanged.

Desktop report focus before and after

Open in Capy

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9214796b-8a84-4f72-9722-0f72e6582387

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zortos293
zortos293 merged commit 39d4b29 into dev Oct 6, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant