Repository navigation
fix(qt): keep desktop session reports in control of focus - #1126
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newly enabled desktop session-report path from #1123 opens after navigation to game details. The details modal's deferred focus callback could then take focus from the report, leaving Return and Space routed to the background game action.
Both new tests failed before the fix and pass afterward. 466/466 Qt CTest targets, 217 Python contracts, localization validation, and
git diff --checkpass. Fresh active-window fixtures exercise actual mocked stop responses through report construction, Done/Diagnostics, disabled reports and unavailable/error telemetry, plus Return/Space isolation. Preserved Store/chip/Friends regressions and all 16 deferred screenshot window/motion cases pass.The grouped post-merge audit used the actual #1124 and #1123 landed trees separately, then this fix. These are credential-free Linux Qt fixtures, not live gameplay, physical-controller, hardware decode/HDR, Windows UI, Wayland, physical DPR/monitor migration, audible/system-mute, or Flatpak acceptance. Report data, layouts and native media are unchanged.