fix(streaming): complete WebRTC startup and default alliance accounts to compatibility mode - #1098
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete native WebRTC startup
Initiate DTLS for actpass offers while preserving the correct ICE role against ICE-lite servers. Explicit active/passive offers retain complementary roles. Add bounded connection diagnostics that report candidate classes, ports, handshake state, and packet counts without addresses, credentials, SDP, or payloads.
Keep the desktop and console video items visible during connection and reconnection so the GPU context can initialize before the first frame. Gameplay focus and input still wait for streaming, and local overlays retain their input guards. This removes the circular wait between hidden video presentation and the first-frame status.
Choose transport by provider, with manual overrides
The new default Automatic mode chooses WebRTC for authenticated alliance providers and NVST for NVIDIA. Users can explicitly select WebRTC or NVST for either account type. The core resolves the provider before codec validation and allocation; existing seats retain their original transport.
Persist the choice as
webrtcCompatibilityModewithauto,on, andoffvalues. Migrate an older explicit WebRTC opt-in toon, and the old default-off value toauto. Keep the historical boolean as a compatibility alias, with synchronized settings events. The UI retains the lower-performance warning and the 1080p60 H.264 SDR/stereo, no-microphone, no-clipboard, direct-UDP limitations.Verification
Account-free Qt settings preview:
Follow-up to the already-merged #1089.