Repository navigation
fix(qt): preserve console controls during stream connection - #1101
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep connection controls focused
#1098 made the console video item visible before the first frame so graphics could initialize. The item remained enabled, so a background click reached its native mouse handler and moved keyboard focus from Stop session to the non-playing video item. Gameplay input stayed blocked, but Return no longer activated the shell control.
Keep the console item visible and alive during connection/reconnection, but enable it only while streaming. This prevents pointer and Tab focus from entering the connecting presenter without changing the graphics initialization or overlay input guards.
Matched 960×540 captures and actual QQuickWindow mouse/key events pass on first parent
44296adc, fail on merged1f29d915, and pass with this fix:Regression coverage
The audit also compared the exact parent and merge across the shared 44-case screen matrix and Network/Audio/Appearance fixtures, including compact UI scale 1.25, provider/override/pending-write states, resizing, German locale and synthetic long German copy. No additional user-facing regression was confirmed in that coverage.
Linux fixtures use software Vulkan and mocked account/native commands. They do not certify hardware decoding/import, live NVIDIA/alliance transport, physical controllers, Wayland, or monitor/DPR migration. Audit renders use SDR and keep the HDR AI filter off.