fix(stargate-bench): measure validated stream output - #1826
Draft
barrygreengus wants to merge 2 commits into
Draft
fix(stargate-bench): measure validated stream output#1826barrygreengus wants to merge 2 commits into
barrygreengus wants to merge 2 commits into
Conversation
barrygreengus
added this pull request to stack #1821
September 11, 2026 21:49
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Validate SSE completion and parse reported output usage instead of crediting requested tokens. Preserve requested workload fields, mark missing usage as unknown, and run benchmark regressions through Bazel. Refs: #1817
Resolve benchmark scenarios from declared runfiles so the full benchmark test suite runs in a clean Bazel sandbox. Refs: #1817
barrygreengus
force-pushed
the
codex/stargate-maintenance/benchmarks
branch
from
September 11, 2026 22:10
96fd955 to
54b3e6e
Compare
Contributor
🛡️ CodeQL Analysis🚨 Found 5 issue(s) Severity Breakdown:
📋 Top Issues🔗 View full details in Security tab 🕐 Last updated: 2026-09-11 22:27:38 UTC | Commit: 54b3e6e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The benchmark driver treated an empty 200 response as success and the scorer credited requested output tokens as generated output. This could report output throughput without completed inference output.
What changed
Customer Release Notes
Stargate benchmarks report observed output usage and reject empty or truncated success responses. Missing usage is reported as unavailable instead of estimated from the request.
Plan Summary
Not applicable.
Usage
Request results include observed_output_tokens. Existing output_tokens fields retain the requested workload count. Older result files remain readable; output metrics are unavailable when observed usage is absent.
Testing
The rebased Cargo workspace passed all 1,611 tests, with 3 existing ignored performance tests. Workspace Clippy passed for all targets with warnings denied. All 161 benchmark tests also passed through Bazel with declared scenario runfiles. Coverage includes empty and truncated responses, fragmented UTF-8, role-only chunks, observed usage, stale counters, missing usage, and legacy result files. No GPU or live-cluster performance campaign was run.
Notes
Final layer of the Stargate maintenance stack. Earlier layers fix protocol handling, proxy and relay lifetime, pylon request ownership, and registration recovery. The streaming deadline finding was already fixed by #1452 and verified by the workspace tests.
Issues
Closes #1817
References
None.
Related Pull Requests
Depends on #1823. Stack, bottom to top: #1818, #1820, #1822, #1823, #1826.
Dependencies
No added or upgraded dependencies. No license or NOTICE changes.