fix(stargate): back off discovery and report registration failures - #1823
Draft
barrygreengus wants to merge 1 commit into
Draft
fix(stargate): back off discovery and report registration failures#1823barrygreengus wants to merge 1 commit into
barrygreengus wants to merge 1 commit into
Conversation
barrygreengus
added this pull request to stack #1821
September 11, 2026 21:33
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This was referenced Sep 11, 2026
Apply kube watcher backoff, report non-TLS registration and stream failures with bounded repetition, and keep secret-file excerpts out of diagnostics. Enable the existing Tokio test-util feature for deterministic watcher testing; no dependency version changes. Refs: #1817
barrygreengus
force-pushed
the
codex/stargate-maintenance/registration
branch
from
September 11, 2026 22:10
28e4124 to
b4c0176
Compare
Contributor
🛡️ CodeQL Analysis🚨 Found 5 issue(s) Severity Breakdown:
📋 Top Issues🔗 View full details in Security tab 🕐 Last updated: 2026-09-11 22:27:59 UTC | Commit: b4c0176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Persistent Kubernetes API errors were retried immediately. Pylon registration and discovery logged certificate failures but discarded other connection, authentication, configuration, and stream errors, obscuring recovery failures.
What changed
Customer Release Notes
Stargate discovery backs off during Kubernetes API failures. Pylon reports actionable registration failures without repeating identical errors continuously or exposing token-file contents.
Plan Summary
Not applicable.
Usage
Registration warnings include the failed operation, endpoint identity, and cause. Certificate-specific diagnostics retain their existing categories and corrective guidance.
Testing
The rebased stack tip passed all 1,611 Cargo workspace tests, with 3 existing ignored performance tests. Workspace Clippy passed with warnings denied. The Kubernetes router Bazel target passed. A fake Kubernetes service and paused clock verify watcher backoff. Diagnostics tests cover causes, repetition, recovery, and secret-file redaction. No live cluster was used.
Notes
Layer 4 of the Stargate maintenance stack. No new metrics or configuration controls.
Issues
Relates to #1817
References
Kube watcher backoff
Related Pull Requests
Depends on #1822. Next layer: #1826.
Dependencies
No added or upgraded dependency versions. Enabled the existing Tokio test-util feature for deterministic watcher tests and refreshed Bazel metadata. No license or NOTICE changes.