refactor(updater): remove unreachable background updater - #34
Merged
Conversation
Base automatically changed from
dependabot/cargo/cargo-security-20929a6c8c
to
main
September 2, 2026 19:26
rldyourmnd
enabled auto-merge
September 2, 2026 19:27
auto-merge was automatically disabled
September 2, 2026 19:30
Pull request was closed
rldyourmnd
enabled auto-merge
September 2, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dormant automatic update scheduler and the unreachable privileged installer paths. The client no longer retains a background release lookup or download path.
The small replacement module keeps only active-session safety checks and validation for a user-initiated release asset download. Its allowlist now names the actual
NDDev-OpenNetwork/nremoterelease path; the previous condition and its tests disagreed and could never accept a real nremote asset.This PR is temporarily stacked on #33 so its three-platform build can run without duplicating the in-flight security dependency migration. It will be retargeted to
mainafter #33 merges.Local checks:
scripts/brand.py --check;scripts/configure.py --check;scripts/check_protocol_parity.py; commitlint controls;git diff --check. Full application compilation is delegated to the repository build workflow because its native codec dependencies are supplied by the pinned vcpkg environment.