refactor(crypto): share byte-compatible Ed25519 signing - #35
Open
rldyourmnd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves client authentication signing to the same byte-compatible
ed25519-dalekimplementation as nremote-server PR #14. Persisted 64-byte device keypairs andsignature || messagepayloads remain unchanged.The signer source is byte-identical in the client and server branches. RFC 8032 vector 1 produces the exact required signature, malformed stored keypairs are rejected, and modified signatures fail verification.
sodiumoxideremains only for the separatebox_and XSalsa20-Poly1305secretboxprotocol operations.This PR is temporarily stacked on #34 and will be retargeted to
mainonce that cleanup merges.Validation:
cargo test --locked --all-targets --manifest-path libs/hbb_common/Cargo.toml: 103 passedgit diff --check