Skip to content

Say the NCode Review Approver meets the required approval - #473

Merged
polewskm merged 10 commits into
mainfrom
worktree-issue-466
Nov 21, 2026
Merged

polewskm merged 10 commits into
mainfrom
worktree-issue-466

Conversation

@polewskm

Copy link
Copy Markdown
Collaborator

Several texts the template ships still carried v0.110.0's claim that GitHub counts no approval from NCode Review. Where NCode Review's approver is set up, they now say the NCode Review Approver's approval meets the ruleset's required approval, of the last push, with one writer too, as ADR-0036 decided. They keep the case without the approver, as ADR-0034 says.

  • Changed in the template: AGENTS.md's draft key, CONTRIBUTING.md's Make a Change item 6 and GOVERNANCE.md's Automation row (the .jinja copies under template/), the message Copier prints after a project is made, which now also names -ApproverPrivateKeyPath, and /best-practices' Branch-Protection row, regenerated with tools/Update-Template.ps1.
  • Changed outside the template: the root README's update note.
  • tools/Dismiss-ScorecardAlerts.ps1's Branch-Protection dismissal comment is now true with and without the approver. Its test and its mentions in the README and docs/adopt.md changed with it. No decision record changes.
  • Adds the v0.111.2 changelog section.

Protected paths changed:
.claude/commands/best-practices.md
.github/prompts/best-practices.prompt.md
.github/skills/best-practices/SKILL.md
template/.claude/commands/best-practices.md
template/.github/prompts/best-practices.prompt.md
template/.github/skills/best-practices/SKILL.md

Release: v0.111.2
Closes #466

@polewskm polewskm self-assigned this Nov 21, 2026
@polewskm
polewskm marked this pull request as ready for review November 21, 2026 21:07

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 6fb01da: 2 new findings on the changed lines.

Comment thread tools/Dismiss-ScorecardAlerts.ps1 Resolved
Comment thread CHANGELOG.md Resolved
@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Superseded by the review at 759e4ec.

@polewskm

Copy link
Copy Markdown
Collaborator Author

/review

@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 6fb01da: 3 hunks in 3 files and changes taken back in 2 files, by correctness only. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.04 on Amazon Bedrock, 11s, at 759e4ec. (how to interact)

📋 Outcomes

Merged at 759e4ec: 1 fixed, 1 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 rule-check 🟠 Should fix ✅ fixed
F2 rule-check 🟡 Nit 👎 dismissed

@polewskm
polewskm enabled auto-merge November 21, 2026 21:24
@polewskm
polewskm merged commit 0944bfa into main Nov 21, 2026
67 checks passed
@polewskm
polewskm deleted the worktree-issue-466 branch November 21, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AGENTS.md and CONTRIBUTING.md say NCode Review's approval meets no required approval, which ADR-0036 amends

1 participant