Repository navigation
Say the NCode Review Approver meets the required approval - #473
Merged
Merged
Conversation
…on reason for the approver
…nt comes from, and log the fix
There was a problem hiding this comment.
🤖 NCode Review at 6fb01da: 2 new findings on the changed lines.
|
Superseded by the review at 759e4ec. |
…-0036, not ADR-0035's table
Collaborator
Author
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at 6fb01da: 3 hunks in 3 files and changes taken back in 2 files, by correctness only. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.04 on Amazon Bedrock, 11s, at 759e4ec. (how to interact) 📋 OutcomesMerged at 759e4ec: 1 fixed, 1 dismissed, 0 acknowledged, 0 ignored.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several texts the template ships still carried v0.110.0's claim that GitHub counts no approval from NCode Review. Where NCode Review's approver is set up, they now say the NCode Review Approver's approval meets the ruleset's required approval, of the last push, with one writer too, as ADR-0036 decided. They keep the case without the approver, as ADR-0034 says.
AGENTS.md'sdraftkey,CONTRIBUTING.md's Make a Change item 6 andGOVERNANCE.md's Automation row (the.jinjacopies undertemplate/), the message Copier prints after a project is made, which now also names-ApproverPrivateKeyPath, and/best-practices' Branch-Protection row, regenerated withtools/Update-Template.ps1.tools/Dismiss-ScorecardAlerts.ps1's Branch-Protection dismissal comment is now true with and without the approver. Its test and its mentions in the README anddocs/adopt.mdchanged with it. No decision record changes.Protected paths changed:
.claude/commands/best-practices.md
.github/prompts/best-practices.prompt.md
.github/skills/best-practices/SKILL.md
template/.claude/commands/best-practices.md
template/.github/prompts/best-practices.prompt.md
template/.github/skills/best-practices/SKILL.md
Release: v0.111.2
Closes #466