Skip to content

Fix NCode Review cooldown pin and shallow-checkout check - #474

Merged
polewskm merged 13 commits into
mainfrom
worktree-issue-464
Nov 21, 2026
Merged

polewskm merged 13 commits into
mainfrom
worktree-issue-464

Conversation

@polewskm

@polewskm polewskm commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

#464: the template's code-review.yml now pins NCode Review v1.5.0 (released 2026-11-21) under ADR-0009's commented exception until its three-day cooldown ends on 2026-11-24. The NCode Review note that .template/Update-Project.ps1 prints also says a project adopts v1.5.0 from that day, or sooner only by such an exception. The help text and README say the same.
#465: the Nerdbank.GitVersioning shallow-clone check in Update-Project.ps1, and its identical copy in tools/adopt/Adoption.psm1, now names only a checkout whose folder holds a build step's working directory. That directory is the step's own working-directory:, else the job's defaults:, else the workflow's. A named checkout's finding shows its path:. When a folder can't be placed, every checkout of the job still counts, as before.
New regression cases in tests/Test-UpdateNotes.ps1 cover both issues, and the docs and the v0.111.2 changelog section describe the changes.

Protected paths changed:
template/.github/workflows/code-review.yml
template/.template/Update-Project.ps1

Release: v0.111.3
Closes #464
Closes #465

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at ee27fdf: 3 new findings on the changed lines.

Comment thread tests/Test-UpdateNotes.ps1 Resolved
Comment thread tests/Test-UpdateNotes.ps1 Resolved
@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Superseded by the review at e1e21b8.

@polewskm polewskm self-assigned this Nov 21, 2026
@polewskm
polewskm marked this pull request as ready for review November 21, 2026 21:23
@polewskm

Copy link
Copy Markdown
Collaborator Author

Autopilot: #473 landed v0.111.2 first and changed CHANGELOG.md and README.md beside this pull request, so it conflicted with main. Step 10 (666ac38) merged origin/main in. It moved this pull request's release to v0.111.3: the changelog's new ## [0.111.3] section holds only this pull request's two Fixed entries. It resolved the README.md paragraph both sides changed by keeping main's text and adding this pull request's ADR-0009 cooldown sentence. Because the branch now holds that merge, this pull request must merge with a merge commit, not by rebasing.

@polewskm

Copy link
Copy Markdown
Collaborator Author

/review

@ncode-review

ncode-review Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at ee27fdf: 6 hunks in 4 files and changes taken back in 4 files, by correctness only. Earlier findings: F1 fixed, F2 fixed, F3 fixed. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.05 on Amazon Bedrock, 9s, at e1e21b8. (how to interact)

📋 Outcomes

Merged at e1e21b8: 3 fixed, 0 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 hygiene, conventions, rule-check 🟡 Nit ✅ fixed
F2 tests, rule-check 🟡 Nit ✅ fixed
F3 tests 🟡 Nit ✅ fixed

@polewskm
polewskm enabled auto-merge November 21, 2026 21:47
@polewskm

Copy link
Copy Markdown
Collaborator Author

Autopilot: this pull request is ready to merge as far as this run can tell.

@polewskm
polewskm merged commit c92e064 into main Nov 21, 2026
67 checks passed
@polewskm
polewskm deleted the worktree-issue-464 branch November 21, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant