Repository navigation
Fix NCode Review cooldown pin and shallow-checkout check - #474
Conversation
There was a problem hiding this comment.
🤖 NCode Review at ee27fdf: 3 new findings on the changed lines.
|
Superseded by the review at e1e21b8. |
|
Autopilot: #473 landed v0.111.2 first and changed |
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at ee27fdf: 6 hunks in 4 files and changes taken back in 4 files, by correctness only. Earlier findings: F1 fixed, F2 fixed, F3 fixed. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.05 on Amazon Bedrock, 9s, at e1e21b8. (how to interact) 📋 OutcomesMerged at e1e21b8: 3 fixed, 0 dismissed, 0 acknowledged, 0 ignored.
|
|
Autopilot: this pull request is ready to merge as far as this run can tell.
|
#464: the template's
code-review.ymlnow pins NCode Review v1.5.0 (released 2026-11-21) under ADR-0009's commented exception until its three-day cooldown ends on 2026-11-24. The NCode Review note that.template/Update-Project.ps1prints also says a project adopts v1.5.0 from that day, or sooner only by such an exception. The help text and README say the same.#465: the Nerdbank.GitVersioning shallow-clone check in
Update-Project.ps1, and its identical copy intools/adopt/Adoption.psm1, now names only a checkout whose folder holds a build step's working directory. That directory is the step's ownworking-directory:, else the job'sdefaults:, else the workflow's. A named checkout's finding shows itspath:. When a folder can't be placed, every checkout of the job still counts, as before.New regression cases in
tests/Test-UpdateNotes.ps1cover both issues, and the docs and the v0.111.2 changelog section describe the changes.Protected paths changed:
template/.github/workflows/code-review.yml
template/.template/Update-Project.ps1
Release: v0.111.3
Closes #464
Closes #465