Skip to content

Pin NCode Review v1.0.0 and record outcomes in a job of its own - #10

Merged
polewskm merged 2 commits into
mainfrom
code-review-v1
Nov 1, 2026
Merged

polewskm merged 2 commits into
mainfrom
code-review-v1

Conversation

@polewskm

@polewskm polewskm commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Moves NCode Review from v0.3.1 to v1.0.0, the first full release, with the caller every other NCodeGroup repository now uses:

  • Adds closed to the pull_request_target types. A separate outcomes job records each finding's outcome when a pull request closes. It runs outside the code-review environment, with no id-token, no Bedrock key and no checkout.
  • A plain /review runs only on an open pull request, so it can't cancel or displace the outcomes run. /review explain and /review teach each run in a concurrency group of their own and still answer on a closed pull request.
  • v1.0.0 runs verification by default and has every engine change since v0.3.1 (changelog).

The file is the canonical caller in NCodeGroup/code-review's .github/workflows/code-review.yml.

Refs NCodeGroup/code-review#97
Refs NCodeGroup/code-review#57

@polewskm
polewskm deployed to code-review November 1, 2026 09:40 — with GitHub Actions Active

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 929c49d: 1 new finding on the changed lines.

Comment thread .github/workflows/code-review.yml Resolved
@ncode-review

ncode-review Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — No findings.

5 reviewers run — 0 findings (run details)

Reviewer Model Findings Top
conventions sonnet-5-5 0 🟢
correctness sonnet-5-5 0 🟢
hygiene haiku-5-5 0 🟢
rule-check sonnet-5-5 0 🟢
security sonnet-5-5 0 🟢

Skipped: api-compat, architecture, completeness, data-model, infrastructure, intent, performance, tests

Trial: findings are posted as review threads and in the check run. $0.18 on Amazon Bedrock, 29s, at c424adf. (how to interact)

📋 Outcomes

Merged at c424adf: 0 fixed, 1 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 hygiene 🟡 Nit 👎 dismissed

@polewskm
polewskm marked this pull request as ready for review November 1, 2026 09:47
@polewskm
polewskm deployed to code-review November 1, 2026 09:47 — with GitHub Actions Active
@polewskm
polewskm merged commit 53177cc into main Nov 1, 2026
9 checks passed
@polewskm
polewskm deleted the code-review-v1 branch November 1, 2026 09:47

This branch was successfully deployed

1 active deployment
code-review — c424adf8 Deployed Nov 1, 2026 by polewskm via review #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant