Skip to content

Update from project-template v0.41.0 to v0.61.2 - #22

Merged
polewskm merged 6 commits into
mainfrom
template-update-v0.61.2
Nov 4, 2026
Merged

polewskm merged 6 commits into
mainfrom
template-update-v0.61.2

Conversation

@polewskm

@polewskm polewskm commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Runs .template/Update-Project.ps1 -Ref v0.61.2 (from v0.41.0) and applies the project-owned changes by hand.

  • Template files replaced/added: workflow commands, agents, skills, instructions, build/dod.ps1, build/Update-PublicApi.ps1, analyzers (banned APIs, PublicApiAnalyzers, Nullable.Extended), CONTRIBUTING.md, SECURITY.md, docs/ scaffolding (docs/README.md, docs/metrics.md, docs/designs/_template.md, docs/decisions/), new workflows (template-update.yml, copilot-setup-steps.yml, code-review-auto-merge.yml), and an updated ci.yml that runs ./build/dod.ps1.
  • .github/workflows/publish.yml from the template is deleted: this project already publishes from a GitHub release through the publish job of main.yml (NuGet API key), and keeping both would publish twice per release. SECURITY.md describes that real path.
  • nuget.config is new: restore is limited to nuget.org.
  • .editorconfig gains the template's file header and generated-code settings; analyzer severities come from the template's build/ProjectTemplate*.globalconfig files.
  • Project-owned files updated by hand: AGENTS.md (new instruction lines, Definition of Done command, Landing keys review-bots, max-review-rounds, prelude, gate: ./build/dod.ps1 -Fast, real conventions; draft: no is the project's existing choice and is unchanged), README.md (Project section), CONTRIBUTING.md (links to AGENTS.md), .github/workflows/code-review.yml.
  • NCode Review moves from v1.0.0 to v1.1.2 (564bb16f8f4f25f88dcc47baae10d7edf55ca504) in code-review.yml, with the review job's concurrency.group line from that release's caller, so a /review comment followed by more lines, such as an agent's --- footer, reviews the pull request instead of cancelling the review in progress. The 3-day dependency cooldown is not met (v1.1.2 was published on 2026-11-02); the maintainer asked for the latest bot, and the comments in the file record this exception.
  • Conflicts resolved: .github/dependabot.yml (took the template's side), global.json (kept the project's SDK 10.0.403, added allowPrerelease: false).
  • Added CHANGELOG.md (Keep a Changelog 1.1.0).

Analyzer fixes

  • Public API: source under NCode.Extensions.DataProtection/ is identical to tag v1.0.1 (only the csproj differs), so the baseline from that release is recorded in PublicAPI.Shipped.txt (-Release); PublicAPI.Unshipped.txt holds only #nullable enable.
  • CA1852: sealed two private test helper classes.
  • Removed GenerateDocumentationFile=false from the test project.
  • No library behavior changed.

Behavior change to know about: AssemblyVersion

The template's build props set AssemblyVersion to <major>.0.0.0 when the project does not set one. This project never set it, so releases up to now had AssemblyVersion equal to the version (v1.0.1 shipped as 1.0.1.0). From the next release it is 1.0.0.0 for every 1.x. Recorded in CHANGELOG.md under Changed.

Verification

./build/dod.ps1 -Fast ends with Definition of Done: PASSED (29 tests). The container could not download SDK 10.0.403, so locally I temporarily set global.json to 10.0.114 with rollForward: latestMajor; that change is not committed. CI uses the pinned SDK.

For a person to decide

  • .github/workflows/code-review-auto-merge.yml is new: it auto-merges Dependabot's NCode Review pin bumps (the template's ADR-0006 exception, recorded in AGENTS.md). Keep or remove it.
  • To keep the old AssemblyVersion behavior, set <AssemblyVersion> explicitly in Directory.Build.props.
  • Moving to NuGet trusted publishing later means restoring the template's publish.yml and removing the main.yml publish job.
  • Existing PR ci: pin third-party actions to commit SHAs #20 (pin third-party actions) touches main.yml, which this update does not change, so the two merge cleanly.

Refs #20

@ncode-review ncode-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 NCode Review at 2151ba7: 6 new findings on the changed lines.

Comment thread .github/workflows/ci.yml Resolved
Comment thread .github/workflows/publish.yml Resolved
Comment thread CHANGELOG.md Resolved
Comment thread docs/metrics.md Resolved
Comment thread docs/metrics.md Resolved
@ncode-review

ncode-review Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Superseded by the review at 86d5c3f.

polewskm commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Autopilot: Round 2 pushed (28ac51b, merge 750571d, 86d5c3f). Beyond the six threads, which are answered individually:

  • CONTRIBUTING.md no longer links to a missing README anchor; it points at AGENTS.md and the template instructions.
  • Deleted the template's publish.yml (the main.yml publish job stays) and reworded SECURITY.md to describe the real publishing path.
  • Replaced the template placeholder under Conventions in AGENTS.md with the repository's real conventions.
  • docs/decisions/README.md index notes that there are no project records yet (numbered from 1000).
  • code-review.yml comments now describe the concurrency group and record the cooldown exception (86d5c3f).
  • The AssemblyVersion change is disclosed in the description and CHANGELOG.md. A person can set <AssemblyVersion> explicitly to keep the old behavior.
  • draft: no in the Landing section is the project's existing choice and is unchanged.

Generated by Claude Code

@polewskm

polewskm commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

/review

@ncode-review

ncode-review Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

🤖 Review complete

Verdict: ✅ Approve — Re-review of what changed since the last review at 2151ba7: 11 hunks in 7 files and changes taken back in 5 files, by correctness only. No further findings above nits.

1 reviewer run — 0 findings (run details)

Reviewer Model Findings Top
correctness sonnet-5-5 0 🟢

Trial: findings are posted as review threads and in the check run. $0.07 on Amazon Bedrock, 14s, at 86d5c3f. (how to interact)

📋 Outcomes

Merged at 86d5c3f: 3 fixed, 3 dismissed, 0 acknowledged, 0 ignored.

Finding Reviewer Severity Outcome
F1 rule-check 🟠 Should fix 👎 dismissed
F2 conventions, rule-check 🟡 Nit 👎 dismissed
F3 hygiene 🟡 Nit ✅ fixed
F4 hygiene 🟡 Nit ✅ fixed
F5 hygiene 🟡 Nit ✅ fixed
F6 intent 🟡 Nit 👎 dismissed

@polewskm
polewskm marked this pull request as ready for review November 4, 2026 01:45
@polewskm
polewskm deployed to code-review November 4, 2026 01:45 — with GitHub Actions Active
@polewskm
polewskm merged commit 9813854 into main Nov 4, 2026
12 of 14 checks passed
@polewskm
polewskm deleted the template-update-v0.61.2 branch November 4, 2026 01:45

This branch was successfully deployed

1 active deployment
code-review — 86d5c3f8 Deployed Nov 4, 2026 by polewskm via review #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant