Repository navigation
Update from project-template v0.41.0 to v0.61.2 - #22
Merged
Merged
Conversation
There was a problem hiding this comment.
🤖 NCode Review at 2151ba7: 6 new findings on the changed lines.
|
Superseded by the review at 86d5c3f. |
Contributor
Author
|
Autopilot: Round 2 pushed (28ac51b, merge 750571d, 86d5c3f). Beyond the six threads, which are answered individually:
Generated by Claude Code |
Contributor
Author
|
/review |
🤖 Review completeVerdict: ✅ Approve — Re-review of what changed since the last review at 2151ba7: 11 hunks in 7 files and changes taken back in 5 files, by correctness only. No further findings above nits. 1 reviewer run — 0 findings (run details)
Trial: findings are posted as review threads and in the check run. $0.07 on Amazon Bedrock, 14s, at 86d5c3f. (how to interact) 📋 OutcomesMerged at 86d5c3f: 3 fixed, 3 dismissed, 0 acknowledged, 0 ignored.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runs
.template/Update-Project.ps1 -Ref v0.61.2(from v0.41.0) and applies the project-owned changes by hand.build/dod.ps1,build/Update-PublicApi.ps1, analyzers (banned APIs, PublicApiAnalyzers, Nullable.Extended),CONTRIBUTING.md,SECURITY.md,docs/scaffolding (docs/README.md,docs/metrics.md,docs/designs/_template.md,docs/decisions/), new workflows (template-update.yml,copilot-setup-steps.yml,code-review-auto-merge.yml), and an updatedci.ymlthat runs./build/dod.ps1..github/workflows/publish.ymlfrom the template is deleted: this project already publishes from a GitHub release through thepublishjob ofmain.yml(NuGet API key), and keeping both would publish twice per release.SECURITY.mddescribes that real path.nuget.configis new: restore is limited to nuget.org..editorconfiggains the template's file header and generated-code settings; analyzer severities come from the template'sbuild/ProjectTemplate*.globalconfigfiles.AGENTS.md(new instruction lines, Definition of Done command, Landing keysreview-bots,max-review-rounds,prelude,gate: ./build/dod.ps1 -Fast, real conventions;draft: nois the project's existing choice and is unchanged),README.md(Project section),CONTRIBUTING.md(links toAGENTS.md),.github/workflows/code-review.yml.564bb16f8f4f25f88dcc47baae10d7edf55ca504) incode-review.yml, with the review job'sconcurrency.groupline from that release's caller, so a/reviewcomment followed by more lines, such as an agent's---footer, reviews the pull request instead of cancelling the review in progress. The 3-day dependency cooldown is not met (v1.1.2 was published on 2026-11-02); the maintainer asked for the latest bot, and the comments in the file record this exception..github/dependabot.yml(took the template's side),global.json(kept the project's SDK 10.0.403, addedallowPrerelease: false).CHANGELOG.md(Keep a Changelog 1.1.0).Analyzer fixes
NCode.Extensions.DataProtection/is identical to tagv1.0.1(only the csproj differs), so the baseline from that release is recorded inPublicAPI.Shipped.txt(-Release);PublicAPI.Unshipped.txtholds only#nullable enable.GenerateDocumentationFile=falsefrom the test project.Behavior change to know about: AssemblyVersion
The template's build props set
AssemblyVersionto<major>.0.0.0when the project does not set one. This project never set it, so releases up to now hadAssemblyVersionequal to the version (v1.0.1 shipped as1.0.1.0). From the next release it is1.0.0.0for every 1.x. Recorded inCHANGELOG.mdunder Changed.Verification
./build/dod.ps1 -Fastends withDefinition of Done: PASSED(29 tests). The container could not download SDK 10.0.403, so locally I temporarily setglobal.jsonto 10.0.114 withrollForward: latestMajor; that change is not committed. CI uses the pinned SDK.For a person to decide
.github/workflows/code-review-auto-merge.ymlis new: it auto-merges Dependabot's NCode Review pin bumps (the template's ADR-0006 exception, recorded inAGENTS.md). Keep or remove it.AssemblyVersionbehavior, set<AssemblyVersion>explicitly inDirectory.Build.props.publish.ymland removing themain.ymlpublish job.main.yml, which this update does not change, so the two merge cleanly.Refs #20