Skip to content

Decisions left after the project-template v0.61.2 and NCode Review v1.1.2 upgrade #24

Open

Description

@polewskm

The upgrade merged in #22 (with #20, the pinned actions). These items need a maintainer's decision or one-time setup.

  • AssemblyVersion. The template's ProjectTemplatePinAssemblyVersion target (build/ProjectTemplate.props, ADR-0136) sets AssemblyVersion to <major>.0.0.0 when the project sets none, and this repo sets none. Releases followed the package version, so the next 1.x release would carry 1.0.0.0, lower than 1.0.1's assembly version. Either set <AssemblyVersion> explicitly in Directory.Build.props or accept the change (it is already noted in CHANGELOG.md).
  • Auto-merge exception. .github/workflows/code-review-auto-merge.yml enables auto-merge on Dependabot pull requests whose only change is the NCode Review pin (ADR-0006's exception). It was kept and the exception is recorded under Conventions in AGENTS.md. Confirm, or delete both.
  • Publishing. main.yml still publishes on release with the NUGET_APIKEY secret; the template's publish.yml was deleted so a release does not publish twice, and SECURITY.md describes the main.yml path. To move to trusted publishing: restore publish.yml, do its one-time nuget.org, nuget environment and NUGET_USER setup, then drop the main.yml publish job and the secret.
  • Retire main.yml's CI. It duplicates the template's ci.yml.
  • Turn on private vulnerability reporting, then remove the hidden maintainer reminder comment from SECURITY.md.
  • main.yml hardening (from the review of ci: pin third-party actions to commit SHAs #20): pass the release tag and the NuGet key through env: instead of expanding them inside run:, harden the push (--skip-duplicate), and consider replacing dorny/test-reporter with a job summary ($GITHUB_STEP_SUMMARY).
  • Changelog: 1.0.0 and 1.0.1 are both dated 2026-01-22 from their tag dates; check them against the releases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions