Skip to content

Add check-gradient-lhs caller - #357

Merged
d-morrison merged 1 commit into
mainfrom
claude/project-thread-yoywtv
Nov 8, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/project-thread-yoywtv

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Wires Morrison-Lab/gha's check-gradient-lhs (gha#1538, from psw#488).

Important

This PR waits on the v3 tag slide, which carries gha#1652. Until then check-caller-permissions fails with a 404 on the new workflow. The runner thread slides the tag; see gha#1654.

Adds .github/workflows/check-gradient-lhs.yml, warn-only (fail is off). This repository has no annotation gate. Infrastructure only.


Generated by Claude Code

Wires Morrison-Lab/gha's check-gradient-lhs (psw#488, gha#1538): a line a
PR adds that says "the gradient is ..." should write the gradient symbol
as the left-hand side of its equation. Warn-only. Part of
Morrison-Lab/gha#1654.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9qHcYVZ9pfvuZZYpVo
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I fetched PR #357 just now. It is open, not a draft, and not merged. Its head is eadff4a9dcaa234f15cdfb0a9f72206dd8494c0d, the commit I reviewed, so the review still applies.

Verdict

Ready for merge, provided the maintainer confirms the reusable workflow check-gradient-lhs.yml exists at Morrison-Lab/gha@v3. The local gha checkout doesn't contain it, and I couldn't query the remote. I found no blocking defects in the diff.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "eadff4a9dcaa234f15cdfb0a9f72206dd8494c0d",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The new caller workflow check-gradient-lhs.yml mirrors sibling thin callers, with correct boolean whole-tree expression and least-privilege permissions; the reusable target could not be found in the local gha checkout.",
  "holistic_assessment": "Scope is a single CI caller with no content or math changes; the remaining integration concern is confirming the upstream reusable workflow exists at the v3 tag before merge."
}

Reviewed commit: eadff4a

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2341 (review) — run

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/pds/pr-preview/pr-357/

Built to branch gh-pages at 2026-11-08 05:50 UTC.

@d-morrison
d-morrison merged commit 8abef74 into main Nov 8, 2026
43 of 44 checks passed
@d-morrison
d-morrison deleted the claude/project-thread-yoywtv branch November 8, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants