Repository navigation
Add check-gradient-lhs caller - #357
Merged
Merged
Conversation
Wires Morrison-Lab/gha's check-gradient-lhs (psw#488, gha#1538): a line a PR adds that says "the gradient is ..." should write the gradient symbol as the left-hand side of its equation. Warn-only. Part of Morrison-Lab/gha#1654. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9qHcYVZ9pfvuZZYpVo
This was referenced Nov 8, 2026
Contributor
|
Claude finished review — View run I fetched PR #357 just now. It is open, not a draft, and not merged. Its head is VerdictReady for merge, provided the maintainer confirms the reusable workflow Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "eadff4a9dcaa234f15cdfb0a9f72206dd8494c0d",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The new caller workflow check-gradient-lhs.yml mirrors sibling thin callers, with correct boolean whole-tree expression and least-privilege permissions; the reusable target could not be found in the local gha checkout.",
"holistic_assessment": "Scope is a single CI caller with no content or math changes; the remaining integration concern is confirming the upstream reusable workflow exists at the v3 tag before merge."
}Reviewed commit: eadff4a |
Contributor
Contributor
Built to branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires
Morrison-Lab/gha'scheck-gradient-lhs(gha#1538, from psw#488).Important
This PR waits on the
v3tag slide, which carries gha#1652. Until thencheck-caller-permissionsfails with a 404 on the new workflow. The runner thread slides the tag; see gha#1654.Adds
.github/workflows/check-gradient-lhs.yml, warn-only (failis off). This repository has no annotation gate. Infrastructure only.Generated by Claude Code