[d-morrison]

Requested by Ezra · project thread

Wires Morrison-Lab/gha's check-gradient-lhs (gha#1538, from psw#488), the same caller as pds#357.

Important

This PR waits on the v3 tag slide, which carries gha#1652. Until then check-caller-permissions fails with a 404 on the new workflow. The runner thread slides the tag; see gha#1654.

Adds .github/workflows/check-gradient-lhs.yml, warn-only (fail is off). This repository has no annotation gate. Infrastructure only.

---

Generated by Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[github-actions]

Claude finished review — View run

---

The "fail default" suggestion in my last message wasn't a missing tool. The file doesn't exist upstream, so there was nothing to install. I confirmed that directly with git ls-remote against Morrison-Lab/gha. main and v3 both exist, and neither has a check-gradient-lhs ref. The raw-file requests returned 404 for check-gradient-lhs.yml on both refs. The same request for check-avoided-words.yml@v3 returned 200.

That makes the blocking finding stronger, and the suggestion moot. The caller can't resolve at all, so its default fail behavior can't be checked.

Findings

Blocking: .github/workflows/check-gradient-lhs.yml:23 calls a reusable workflow that doesn't exist.

• Morrison-Lab/gha/.github/workflows/check-gradient-lhs.yml@v3 is not in the repo at v3 (014b007) or at main (d38e14e).
• Every PR and manual run of this caller will fail at startup.
• Fix: release the upstream workflow (psw#488, gha#1538) and move the v3 tag first, or hold this PR until then.

Verdict

Needs more work

Structured Review Data (JSON)

{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "00cdad681210620d3224fe87aa7b19da514c5249",
  "verdict": "NOT_CLEAN",
  "findings": [
    {"file": ".github/workflows/check-gradient-lhs.yml", "line": 23, "category": "bug", "message": "The reusable workflow Morrison-Lab/gha/.github/workflows/check-gradient-lhs.yml@v3 does not exist at v3 or main, so the caller cannot resolve and will fail on every PR. Release the upstream workflow and move the v3 tag first."}
  ],
  "detailed_assessment": "The new caller workflow at line 23 references a gha reusable workflow at @v3 that is absent from the repo at v3 and main, so the job cannot start.",
  "holistic_assessment": "The PR is scoped and follows the existing caller pattern. It depends on an unreleased upstream workflow, so the integration cannot be validated until gha publishes it."
}

@claude address review comments in [this review](https://github.com/Morrison-Lab/ids/pull/105)

Reviewed commit: 00cdad6

[github-actions]

💰 Cost: $0.2280 (review) — run

[github-actions]

PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/ids/pr-preview/pr-105/

_{Built to branch gh-pages at 2026-11-08 05:40 UTC.}

[github-actions]

Claude finished review — View run

---

I fetched PR #105 live. It is OPEN, not a draft, not merged (mergedAt is null), and its head is still 00cdad681210620d3224fe87aa7b19da514c5249, the commit I reviewed. The review therefore still applies.

I did not run the new workflow. The upstream check-gradient-lhs.yml now resolves at Morrison-Lab/gha@v3 (HTTP 200), and its inputs match what the caller passes.

Verdict

Ready for merge

Structured Review Data (JSON)

{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "00cdad681210620d3224fe87aa7b19da514c5249",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The new caller workflow check-gradient-lhs.yml references an upstream reusable workflow that now exists at v3 and main, and its inputs match the declared ones.",
  "holistic_assessment": "The change is scoped to one caller file following the existing pattern, and the earlier dependency on an unreleased upstream workflow is resolved."
}

Reviewed commit: 00cdad6

[github-actions]

💰 Cost: $0.2011 (review) — run