Repository navigation
feat: DrawerSection hook in SyncHooks, rendered in FolderDrawer - #76
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
MaxDac
enabled auto-merge (squash)
November 5, 2026 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the GitHub Issues integration; closes #74.
What
SyncHooksgets a generic hook with an empty default:@Composable fun ColumnScope.DrawerSection(navController: NavController) {}(
app-shared/.../sync/SyncHooks.kt).NoSyncHooksdoes not override it, so Libre shows nothing.FolderDrawerrendersdrawerSection()after the notes tree, inside theModalDrawerSheetcolumn. The tree'sLazyColumnnow hasModifier.weight(1f, fill = false)so it keeps its natural height (identical layout when the section is empty) and a long tree scrolls above the section instead of pushing it off screen.BrowserScreengets a trailing parameterdrawerSection: @Composable ColumnScope.() -> Unit = {}(default: source compatible);MainActivitypasses{ with(container.syncHooks) { DrawerSection(navController) } }.app-sharedandroidTestFolderDrawerSectionTest(default hook renders nothing; a fake hook renders in the drawer). Adds theui-test-junit4/ui-test-manifesttest deps (already in the catalog) to:app-shared.For the Pro session
Override in the
SyncHooksimplementation:The change is additive (interface default method plus a defaulted parameter); no Pro source change is required to compile.
FolderDrawerbecameinternal(was private). No new runtime dependencies, nothing network-related; F-Droid build unaffected.Verified locally
ktlintCheck detekt lintDebug testDebugUnitTest :app-shared:compileDebugAndroidTestKotlin :app:compileDebugKotlinpass. Instrumented tests were not run locally (no emulator); they run in CI.🤖 Generated with Claude Code