Skip to content

Drawer hook: DrawerSection in SyncHooks, rendered in FolderDrawer #74

Closed

Description

@MaxDac

Part of the GitHub Issues integration. Design and decisions: ~/.claude/plans/plan-the-inclusion-of-whimsical-rocket.md. Handoff: ~/.claude/plans/github-issues-handoff.md. Contract: marknotes-spec issues.md (on main). Engine: marknotes-sync PR #23 (merged). Web is out of scope; Libre only gets a generic hook.

Work

Add the generic hook Pro uses to show the Issues accordion in the left drawer. Libre knows nothing about GitHub.

  • Add @Composable fun ColumnScope.DrawerSection(navController: NavController) with an empty default to the existing SyncHooks, and render it in FolderDrawer (app-shared/.../ui/browser/BrowserScreen.kt) after the notes tree.
  • Keep Libre behaviour and screenshots unchanged when the hook is the default.
  • Tests: a Compose/unit test that the default renders nothing and a fake hook renders in the drawer; keep F-Droid reproducibility and shared-module compatibility for Pro (the source tree is consumed by gitlink).
  • Merge to main; the new commit is what Pro will pin. Comment its SHA here.

Done when

PR merged, CI green, SHA commented.

Activity

  1. MaxDac commented on Nov 5, 2026

    @MaxDac
    OwnerAuthor

    PR #76 open with auto-merge. Note: the issue's hook is added as specified; BrowserScreen gets a defaulted trailing drawerSection parameter and the tree LazyColumn uses weight(1f, fill=false) so the section stays visible. Merge SHA will be commented once merged.

  2. MaxDac commented on Nov 5, 2026

    @MaxDac
    OwnerAuthor

    Merged via #76 as 23e38fcdfbbf26fee062cc014a3a6a2858a338f7 (on main). Pro should pin this commit or newer. API: @Composable fun ColumnScope.DrawerSection(navController: NavController) {} on SyncHooks, empty default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions