Repository navigation
GH Issue 1695: Require group-owning container for all group membership changes - #8273
Merged
labkey-adam merged 2 commits intoNov 3, 2026
Merged
Conversation
labkey-adam
requested review from
labkey-jeckels,
labkey-klum and
labkey-matthewb
November 2, 2026 19:02
labkey-matthewb
requested changes
Nov 2, 2026
labkey-matthewb
left a comment
Contributor
There was a problem hiding this comment.
Claude points out that the AddUser with clone option should require SiteAdmin (related but differnt action).
Contributor
Author
There's a separate OWASP issue for that: https://github.com/LabKey/internal-issues/issues/1696 I'll address it shortly in 26.11, but I want to make service team and product managers aware first. |
labkey-matthewb
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Group membership changes are now always made from the container that owns the group, with the same checks applied everywhere members are added or removed, including folder import. GH Issue 1695
Related Pull Requests
Changes