Skip to content

GH Issue 1695: Require group-owning container for all group membership changes - #8273

Merged
labkey-adam merged 2 commits into
release26.11-SNAPSHOTfrom
26.11_fb_group_membership_container_1695
Nov 3, 2026
Merged

labkey-adam merged 2 commits into
release26.11-SNAPSHOTfrom
26.11_fb_group_membership_container_1695

Conversation

@labkey-adam

Copy link
Copy Markdown
Contributor

Rationale

Group membership changes are now always made from the container that owns the group, with the same checks applied everywhere members are added or removed, including folder import. GH Issue 1695

Related Pull Requests

Changes

  • Site group membership can be changed only from the root, and project group membership only from its own project
  • Folder import always updates project groups, regardless of the group type in the archive
  • Site Users and Guests group membership can't be changed by anyone
  • Added integration tests for each case

@labkey-matthewb labkey-matthewb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude points out that the AddUser with clone option should require SiteAdmin (related but differnt action).

@labkey-adam

Copy link
Copy Markdown
Contributor Author

Claude points out that the AddUser with clone option should require SiteAdmin (related but differnt action).

There's a separate OWASP issue for that: https://github.com/LabKey/internal-issues/issues/1696

I'll address it shortly in 26.11, but I want to make service team and product managers aware first.

@labkey-adam
labkey-adam merged commit 07441bb into release26.11-SNAPSHOT Nov 3, 2026
11 checks passed
@labkey-adam
labkey-adam deleted the 26.11_fb_group_membership_container_1695 branch November 3, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants