Repository navigation
GH Issue 1695: Require group-owning container for all group membershi… - #8264
Closed
labkey-adam wants to merge 2 commits into
Closed
labkey-adam wants to merge 2 commits into
labkey-adam wants to merge 2 commits into
Conversation
labkey-adam
requested review from
labkey-jeckels,
labkey-klum and
labkey-matthewb
October 31, 2026 05:14
Contributor
Author
|
Superseded by #8273, which targets release26.11-SNAPSHOT; the fix reaches develop via the release merge-forward. |
labkey-adam
added a commit
that referenced
this pull request
Nov 3, 2026
…p changes (#8273) ## Rationale Group membership changes are now always made from the container that owns the group, with the same checks applied everywhere members are added or removed, including folder import. [GH Issue 1695](LabKey/internal-issues#1695) ## Related Pull Requests - Replaces #8264, which targeted develop ## Changes - Site group membership can be changed only from the root, and project group membership only from its own project - Folder import always updates project groups, regardless of the group type in the archive - Site Users and Guests group membership can't be changed by anyone - Added integration tests for each case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…p changes
Rationale
Group membership changes are now always made from the container that owns the group, with the same checks applied everywhere members are added or removed, including folder import. GH Issue 1695
Changes