Skip to content

Search online for the selected process image name - #36

Merged
JamesLinYJ merged 4 commits into
mainfrom
cursor/search-online-0b05
Oct 20, 2026
Merged

JamesLinYJ merged 4 commits into
mainfrom
cursor/search-online-0b05

Conversation

@JamesLinYJ

Copy link
Copy Markdown
Owner

Summary

  • Add a Processes context command, Search online, that searches the web for the selected process image name.
  • The command stays disabled unless the row has a verified ProcIdentity and a real image name. The worker reopens that identity and does not fall back to a PID-only open.
  • The search runs on a background worker. Failure is shown in a dialog on the UI thread as soon as the worker returns.

Test

  • cargo check --all-targets --locked passed locally.
  • Unit tests cover image-name checks, URL encoding, unverified identities, and access-denied versus identity-mismatch results. Linking those tests needs the Windows MSVC linker, which this environment does not have.
Open in Web Open in Cursor 

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T04:08:39.043417Z d28f71d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Add a Processes context command that opens a web search for a verified
image name on a background worker and shows a dialog when the search fails.

Co-authored-by: jameslincn <jameslincn@outlook.sg>
@cursor
cursor Bot force-pushed the cursor/search-online-0b05 branch from d28f71d to 4db8501 Compare October 20, 2026 04:07

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d28f71d5de

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/pages/processes/search.rs Outdated
cursoragent and others added 2 commits October 20, 2026 04:09
PWM_PROC_SEARCH_COMPLETE moves to 0x0400+28 so it does not share
0x0400+27 with the dump worker.

Co-authored-by: jameslincn <jameslincn@outlook.sg>
A CoInitializeEx result outside FACILITY_WIN32 is recorded and shown as
that HRESULT instead of ERROR_GEN_FAILURE.

Co-authored-by: jameslincn <jameslincn@outlook.sg>
Clippy rejects assigning fields after SHELLEXECUTEINFOW::default().

Co-authored-by: jameslincn <jameslincn@outlook.sg>
@JamesLinYJ
JamesLinYJ merged commit cfc3195 into main Oct 20, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants