Repository navigation
fix: integrate pending features and repair cross-feature regressions - #40
Merged
Merged
Conversation
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 8.0.1 to 8.0.2. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@3e5f45b...9000827) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: 8.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@043fb46...cf430e0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 7.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Add a classic Filter field on the Processes page. The filter is a UI-thread view of the committed snapshot, so sampling, tokens, and icons stay on the worker. Selection is kept by ProcIdentity across refresh, including when a row is hidden and the filter is later cleared. Co-authored-by: jameslincn <jameslincn@outlook.sg>
A missing target left the previous filtered rows on screen until the next snapshot, and a failed collection could keep that mismatch. Apply the empty filter to the committed snapshot before scheduling collection. The filter tests now use a needle that matches only alpha.exe. Co-authored-by: jameslincn <jameslincn@outlook.sg>
List Run-key and Startup-folder entries, and enable or disable them through StartupApproved without deleting the original entry. Queries stay on the background worker, and a failed change is shown immediately. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Treat StartupApproved 0x07 as disabled and write 0x07 when disabling a 0x06 entry. When one startup source fails, keep that source's previous rows and show them as not refreshed. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Sample physical-disk byte counters on the existing system worker and draw active time with the same history graph as CPU and memory. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Each successful IOCTL_DISK_PERFORMANCE increments the driver's reference count. Track those successes, keep one enable while the handle is open, and issue IOCTL_DISK_PERFORMANCE_OFF for the rest, including worker shutdown and a drive that disappears. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Grow the process column list through an options schema 3 migration that keeps the existing binary fields in place. Sample the new counters on the process worker, and leave a failed row unknown instead of zero. Accept command lines up to the UNICODE_STRING limit of 32,767 code units, and size the query buffer to include the UnicodeString header. Co-authored-by: jameslincn <jameslincn@outlook.sg>
…uilds Preserve stable selections and correlate asynchronous process navigation, including the current process-tree UI. Prevent service controls from being discarded and avoid presenting unavailable samples as valid zeros. Correct native UI and buffer handling, bound diagnostic flush and shutdown work, and make build scripts preserve failures and argument boundaries. Add regression coverage and run PowerShell script tests in CI. Co-authored-by: OpenAI Codex <codex@openai.com>
The process context menu writes a full-memory dump only after open_process_for_identity confirms the pid and creation time. The save dialog stays on the UI thread; MiniDumpWriteDump runs on a persistent worker, and failure is reported immediately. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Shutdown no longer joins the dump thread. Failed partial files are deleted and a cleanup error is reported. MiniDumpWriteDump shares one nonblocking gate with the crash handler, and partial names are created with CREATE_NEW. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Add a Processes context command that opens a web search for a verified image name on a background worker and shows a dialog when the search fails. Co-authored-by: jameslincn <jameslincn@outlook.sg>
PWM_PROC_SEARCH_COMPLETE moves to 0x0400+28 so it does not share 0x0400+27 with the dump worker. Co-authored-by: jameslincn <jameslincn@outlook.sg>
A CoInitializeEx result outside FACILITY_WIN32 is recorded and shown as that HRESULT instead of ERROR_GEN_FAILURE. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Services can pause a running service and continue a paused one through the existing background worker, using the same failure dialog as start and stop. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Toggle WS_EX_TOPMOST from the View menu with IDM_ALWAYSONTOP and a checkmark. The choice lasts for the session and is not written into Options. Co-authored-by: jameslincn <jameslincn@outlook.sg>
# Conflicts: # src/pages/processes/mod.rs
# Conflicts: # build_support/localization.rs # localization/de.toml # localization/en_us.toml # localization/es.toml # localization/fr.toml # localization/pt.toml # localization/ru.toml # localization/zh_cn.toml # localization/zh_tw.toml # src/app/mod.rs # src/app/page_host.rs # src/pages/processes/mod.rs # src/ui/localization/text_key.rs # src/ui/resource_ids.rs
# Conflicts: # src/pages/services/model.rs # src/pages/services/sampler.rs
# Conflicts: # src/pages/processes/mod.rs
# Conflicts: # localization/de.toml # localization/en_us.toml # localization/es.toml # localization/fr.toml # localization/pt.toml # localization/ru.toml # localization/zh_cn.toml # localization/zh_tw.toml # src/app/page_host.rs # src/pages/performance/mod.rs # src/ui/localization/text_key.rs
# Conflicts: # README.md # README.zh-CN.md # build_support/localization.rs # docs/compatibility-matrix.md # localization/de.toml # localization/en_us.toml # localization/es.toml # localization/fr.toml # localization/pt.toml # localization/ru.toml # localization/zh_cn.toml # localization/zh_tw.toml # src/app/mod.rs # src/app/page_host.rs # src/ui/dialogs.rs # src/ui/localization/text_key.rs # src/ui/resource_ids.rs
# Conflicts: # build_support/localization.rs # localization/de.toml # localization/en_us.toml # localization/es.toml # localization/fr.toml # localization/pt.toml # localization/ru.toml # localization/zh_cn.toml # localization/zh_tw.toml # src/app/page_host.rs # src/pages/processes/mod.rs # src/ui/dialogs.rs # src/ui/localization/text_key.rs # src/ui/menus.rs # src/ui/resource_ids.rs
View → Always on Top is session-only, so the registry setter had no caller and failed clippy. Co-authored-by: JamesLinYJ <JamesLinYJ@users.noreply.github.com>
Walk FirstUnicastAddress and keep only AF_INET. A failed query stays Unknown, and an adapter with no IPv4 stays "-". Co-authored-by: JamesLinYJ <JamesLinYJ@users.noreply.github.com>
Clippy rejects assigning fields after SHELLEXECUTEINFOW::default(). Co-authored-by: jameslincn <jameslincn@outlook.sg>
JamesLinYJ
marked this pull request as ready for review
October 20, 2026 04:58
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
整合当前全部 12 个功能/依赖 PR，并完成先前已确认的五项安全与性能修复。使用 merge commit 保留原 PR 的提交关系。
包含：#23、#24、#27、#28、#30、#31、#35、#36、#37、#38、#39、#41。
修复：
验证（最终提交
3c636bb）：cargo check --all-targets --locked、cargo clippy --all-targets --locked -- -D warnings、cargo test --all-targets --locked、cargo build --release --locked；命令均指定相应--target，使用已缓存依赖。cargo fmt --all -- --check、相对 main 的git diff --check、tests/build_scripts.ps1的 3 项回归通过。新增及扩展的回归覆盖真实转储临时文件保存/清理、冻结 ZIP 与日志轮转、默认脱敏/敏感模式/panic/大写崩溃记录、受控阻塞 worker 的退出与通知、D2D/GDI 原生资源、筛选/树选择、菜单勾选、IPv4 失败保留与网卡身份切换、诊断退出回复通道。
关键修复模块：
src/infrastructure/diagnostics/mod.rs、src/app/diagnostics_dialog.rs、src/infrastructure/worker.rs、src/pages/cpu/firmware.rs、src/pages/gpu/metadata.rs、src/ui/charts.rs、src/pages/performance/mod.rs、src/pages/processes/、src/pages/network.rs、服务及菜单模块。两次只读安全检查发现的具体问题均已处理。GitHub 托管 Windows CI 在提交合并时仍排队；上述结果来自本地 Windows VM。未将这些结果表述为物理 GPU、真实挂死 WMI provider、保存对话框交互或全部设备兼容性验收。