Repository navigation
feat: create a dump file for the selected process - #35
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3435c5a5bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The process context menu writes a full-memory dump only after open_process_for_identity confirms the pid and creation time. The save dialog stays on the UI thread; MiniDumpWriteDump runs on a persistent worker, and failure is reported immediately. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Shutdown no longer joins the dump thread. Failed partial files are deleted and a cleanup error is reported. MiniDumpWriteDump shares one nonblocking gate with the crash handler, and partial names are created with CREATE_NEW. Co-authored-by: jameslincn <jameslincn@outlook.sg>
cursor
Bot
force-pushed
the
cursor/create-dump-file-ddb0
branch
from
October 20, 2026 04:07
299934b to
ddfd2f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Create Dump File to the Processes context menu.
IDM_PROC_DUMP(40140), with routing, status help, and strings in every locale. It stays disabled unless the selected row has a verifiedProcIdentity.MiniDumpWriteDumpruns on a persistent worker and opens the process withopen_process_for_identityusing onlyPROCESS_QUERY_INFORMATION | PROCESS_VM_READ. A pid-only identity is rejected beforeOpenProcess.Optionsis unchanged.Verification
cargo fmt --allcargo check --all-targets --lockedforx86_64-pc-windows-msvccargo clippy --all-targets --locked -- -D warningsfor the same targetcargo testandcargo build --releasedid not link here: this environment has nolink.exe. That cross typecheck is not a Windows device test. CI should run Quality (x86_64) and Architecture (i686,aarch64).