Repository navigation
Connect report Dashboard and trace to fixed attempt records - #450
Merged
amy-why-3459 merged 1 commit intoNov 15, 2026
Merged
amy-why-3459 merged 1 commit into
amy-why-3459 merged 1 commit into
Conversation
Signed-off-by: zengchuang <zengchuang3@huawei.com> Agent-assisted-by: Codex (author)
4 tasks
amy-why-3459
approved these changes
Nov 15, 2026
amy-why-3459
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 1373ef8 and head d4c2936 (full review, new PR).
Verified:
- Scope matches #371 step 6:
status/trace/report/ offline and--livedashboardall go through the singleread_attempt_viewfrom #449;include_traceonly adds thetraceprojection,statusoutput is unchanged. traceprojectssteps/checks/errorsfield-by-field inside the existing integritytry, so missing fields surface asArtifactIntegrityError; unknown step times staynull.attempt_html.render_attemptescapes every value and the title, ships adefault-src 'none'CSP and exposes no log or artifact paths._write_view_documentreuses the atomic writer and symlink / overwrite checks, with the generator marker scoped per document kind.DashboardServerrequires exactly one of source / fixed attempt, deep-copies the pinned view, and the profile-events route is disabled without a source.- CLI argument guards: I checked locally that
tracerequires--record-ref,report --run-id ... --output, missing--storage-config, fixed report without--outputanddashboard --inputplus--storage-configall fail with clear errors. - I ran
tests/test_apps_*,test_cli_catalog,test_dashboard_*andtest_module_boundarieslocally on this head (Linux, Python venv with[skills]deps) and all passed. All CI checks on the head are green, including full-check 3.10/3.11, installed-package and dashboard-browser.
Accuracy/performance comparison: not applicable (read-only presentation/CLI wiring, no numeric or runtime-path change).
7 tasks
There was a problem hiding this comment.
LGTM
PR review verdict — PASS
Reviewed base 1373ef8ee2a67947cd2503ab527a3b252728611c and head d4c2936584e84498bc9220b4bb338f5c93234237.
Verified:
- Scope matches #371 step 6 surfaces:
status/trace/report/ offline and--livedashboardshareread_attempt_view;include_traceonly adds the projection;statusoutput remains withouttrace. - Trace projection field-selects
steps/checks/errorsinside the integrity try; missing keys raiseArtifactIntegrityError; null step times preserved. attempt_html.render_attemptescapes values/title, uses restrictive CSP, and does not expose log/artifact paths.- Atomic HTML writer retains symlink/overwrite guards with per-kind generator markers.
- Live
DashboardServerrequires exactly one of directory source or fixed attempt; deep-copies the pinned view; profile-events route gated on source. - CLI mutual-exclusion and guards for fixed vs legacy paths are coherent; docs/operations notes the shared refs.
- Local pytest on this head:
test_apps_assess,test_cli_catalog,test_module_boundaries,test_dashboard_live,test_dashboard_data,test_dashboard_externalall passed; ruff clean on touched paths. Ready CI on the head is all success.
Accuracy/performance comparison: not applicable (read-only presentation/CLI wiring).
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Governing issue and delivery slice
Refs #371, step 6. Uses the fixed attempt reader from #449 for
status, HTMLreport, offline and loopbackdashboard, and JSONtrace. Each command accepts the same--record-refand--storage-configfiles, with optional--assessment-reftied to that exact revision. The live Dashboard page and its state endpoint serve the snapshot pinned at startup.traceprojects recorded steps, checks and error codes without synthesizing timestamps. Report and Dashboard present the same execution facts and archived claim outcomes. Their HTML output uses the existing atomic writer and overwrite checks. Legacy paths are covered by the existing CLI and Dashboard regressions.Verification
86306cfdpassed 75 tests and 2 subtests across Apps assessment, context, Knowledge, the live Dashboard and CLI.Production CPU integration still tracks Harness #429/#447 and Benchmark #430/#434.